Merged
Conversation
|
Performance benchmarks:
|
Contributor
Author
|
Performance benchmarks:
|
quaquel
reviewed
Dec 16, 2025
Member
There was a problem hiding this comment.
Can you also add this additional behavior and value error to the docstring?
quaquel
requested changes
Dec 16, 2025
Member
quaquel
left a comment
There was a problem hiding this comment.
One minor addition, but looks fine otherwise. Thanks.
quaquel
approved these changes
Dec 17, 2025
Member
|
Merged and thanks |
Member
|
Thanks for the PR, and the review! (please do check each merged PR has an appropriate release notes label) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR prevents undefined HexGrid configurations by disallowing toroidal grids with odd dimensions, which previously resulted in asymmetric neighbor wiring.
Bug / Issue
Fixes #2811.
HexGrid with torus=True and an odd width or height leads to incorrect neighbor wrapping, where connections are not bidirectional. This configuration was previously allowed without validation, causing undefined behavior.
Implementation
-Added validation in HexGrid._validate_parameters to require even width and height when torus=True.
-A ValueError is raised for invalid configurations to prevent undefined topology.
Testing
-Added tests covering:
Additional Notes
This introduces validation for a previously unsupported configuration, causing affected models to fail fast with a clear error instead of producing inconsistent behavior.