Conversation
|
Hi @EwoutH , I've added the version warnings to all visualization tutorials as requested. The failing CI checks appear to be environment issues (Linux/macOS failing across Python versions, but Windows passes). The documentation builds successfully and pre-commit checks pass. This should resolve the confusion users face when following Mesa 3.3+ tutorials with older versions. |
Srinath0916
force-pushed
the
fix-issue-2837-visualization-version-warning
branch
from
14f2183 to
8c0f05c
Compare
|
Thank you @Srinath0916 for doing this! Please take a look at my comment. |
Srinath0916
force-pushed
the
fix-issue-2837-visualization-version-warning
branch
from
9b88b89 to
c63ab48
Compare
|
Hi @tpike3 , Done, Removed the reference to older tutorial versions from all visualization tutorials. The warnings now only mention upgrading to Mesa 3.3+. Thanks for the feedback! |
|
Thanks for the PR. I agree we could inform users better about this. I find this approach way too aggressive however. Check against |
Srinath0916
force-pushed
the
fix-issue-2837-visualization-version-warning
branch
from
65fd9eb to
507fc27
Compare
|
Hey @EwoutH! You're right, those warnings were way too aggressive. I've removed all the static markdown warnings from the tutorials. Much cleaner now and users will just get natural import errors if they need to upgrade. Could you take another look? Thanks! |
I can't see |
|
Hi @EwoutH @Srinath0916 @tpike3 , I'd like to help implement the mesa.version check. Can I take over this ? |
Srinath0916
force-pushed
the
fix-issue-2837-visualization-version-warning
branch
from
27bf31c to
648c115
Compare
Heyy @Mani212005 thanks for coming front, but i have added the mesa version, thanks! |
|
Hey @EwoutH Note: There's one unrelated test failure in the Schelling visualization test (Playwright screenshot issue), but all other tests pass and this failure isn't related to our version checking changes. Could you take another look? Thanks! |
- Add prominent version requirement warnings to tutorials 4-8 - Include upgrade instructions and alternative solutions - Resolves confusion for users on Mesa 3.2 following 3.3+ tutorials - Addresses missing classes like SpaceRenderer and AgentPortrayalStyle Fixes mesa#2837
Address maintainer feedback by removing the line about following older tutorial versions since no links are available. Co-authored-by: tpike3
- Remove prominent markdown version warnings from tutorials 4-8 - Keep tutorial content clean and focused on actual content - Users will get natural import errors with helpful messages if using older Mesa - Addresses maintainer feedback for less aggressive approach Resolves mesa#2837
- Add dynamic version check using mesa.__version__ in all visualization tutorials - Shows warning only when Mesa < 3.3 is detected - Clean, non-aggressive approach that appears after import - Addresses @EwoutH's specific feedback about version checking
EwoutH
force-pushed
the
fix-issue-2837-visualization-version-warning
branch
from
648c115 to
65398b8
Compare
5 participants
Fixes #2837
Summary
Users following Mesa visualization tutorials encounter import errors when using Mesa 3.2 because the tutorials use classes introduced in Mesa 3.3, but don't clearly state version requirements.
Bug / Issue
Fixes #2837 - Users report confusion and import errors when following visualization tutorials. The tutorials use
SpaceRenderer,AgentPortrayalStyle, andSolaraVizclasses that don't exist in Mesa 3.2, but tutorials don't warn about version requirements.Implementation
pip install --upgrade mesaTesting
Additional Notes
This is a documentation-only fix that will prevent user confusion without any breaking changes. The warnings are designed to be helpful and provide clear next steps for users on older Mesa versions.