Replace deprecated np.bmat with np.block in Voronoi Delaunay triangulation#2915
Merged
Replace deprecated np.bmat with np.block in Voronoi Delaunay triangulation#2915
Conversation
EwoutH
force-pushed
the
voronoi_np_block
branch
2 times, most recently
from
bcbb968 to
0d2c3a7
Compare
Replace np.bmat with np.block in Delaunay._circumcenter to fix PendingDeprecationWarning about numpy.matrix subclass. The nested lists are wrapped in np.array() calls to ensure consistent array depths required by np.block.
EwoutH
force-pushed
the
voronoi_np_block
branch
from
adecb0d to
afb96fb
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
quaquel
approved these changes
Dec 3, 2025
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes 108 deprecation warnings in the test suite related to
numpy.matrixbeing deprecated.Bug / Issue
When running
tests/test_space_drawer.py, NumPy emitsPendingDeprecationWarningfor each call toDelaunay._circumcenter():This occurs because
np.bmatreturns anumpy.matrixobject, which NumPy intends to deprecate in favor of regularndarray.Implementation
In
mesa/discrete_space/voronoi.py, theDelaunay._circumcentermethod usednp.bmatto construct a block matrix. This is replaced withnp.block, wrapping the nested lists innp.array()calls to ensure consistent 2D array depths:Testing
Existing tests pass. The 108
PendingDeprecationWarningmessages fromtest_space_drawer.pyare eliminated.Additional Notes
This is a forward-compatibility fix. When NumPy eventually removes the
matrixsubclass, this code would have broken.Part of #2904.