Fix dtype/default_value mismatches in PropertyLayer tests to resolve UserWarnings#2913
Merged
Fix dtype/default_value mismatches in PropertyLayer tests to resolve UserWarnings#2913
Conversation
|
Performance benchmarks:
|
Member
|
Please give. the PR a clear and descriptive title. |
Contributor
Author
Sure! |
EwoutH
approved these changes
Dec 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed
UserWarningmessages related toPropertyLayerdefault value and dtype mismatches in test files.Bug / Issue #2904
PropertyLayerwas instantiated withdefault_valuetypes that did not match the inferred or specifieddtype.This triggered warnings such as:
Affected Files
tests/test_components_matplotlib.pytests/test_solara_viz.pytests/test_solara_viz_updated.pytests/test_space_renderer.pyImplementation
Explicitly set the
dtypeto match thedefault_valuein all affected tests:dtype=intfordefault_value=0dtype=floatfordefault_value=10.0dtype=floatfordefault_value=10.0dtype=intfordefault_value=0dimensionsto[2, 2]to match thePropertyLayerconstructorTesting
Executed:
pytest tests/test_components_matplotlib.py
tests/test_solara_viz.py
tests/test_solara_viz_updated.py
tests/test_space_renderer.py
Result: All 41 tests passed with no warnings.
Additional Notes
None.