Conversation
|
Performance benchmarks:
|
EwoutH
approved these changes
Dec 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses a deprecation around the old experimental cell space import used in the matplotlib components tests. The tests were importing grid classes from mesa.experimental.cell_space, which is now deprecated in favor of the new mesa.discrete_space API.
What does this PR change?
Updates the import in tests/test_components_matplotlib.py from:
from mesa.experimental.cell_space import (
CellAgent,
HexGrid,
Network,
OrthogonalMooreGrid,
VoronoiGrid,
)
to:
from mesa.discrete_space import (
CellAgent,
HexGrid,
Network,
OrthogonalMooreGrid,
VoronoiGrid,
)
This resolves item 1.3 from issue #2904 by pointing the tests at the official, non‑experimental cell space
implementation.
How did you test it?
Ran the targeted test file:
pytest tests/test_components_matplotlib.py
Re-ran the same test with warnings enabled:
pytest -W always tests/test_components_matplotlib.py
All 7 tests passed, and the previous DeprecationWarning about mesa.experimental.cell_space no longer appears (only unrelated existing warnings remain).