Merged
Conversation
|
Performance benchmarks:
|
tpike3
approved these changes
Jul 26, 2025
Member
tpike3
left a comment
tpike3
left a comment
There was a problem hiding this comment.
Thanks @Tosiekdev!
Merge note: I am ignoring the pre-commit issue as it is based on ruff upgrade and not relevant to PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get_neighborhoodfunction in theNetworkGridnow returns node ids sorted by the distance from the source node.Bug / Issue
Fixes this. Before this changes mentioned function was returning node_ids sorted by its values, and not the distance.
Implementation
Dictionary returned by the NetworkX's
single_source_shortest_path_lengthis sorted by the value of the items, and then the node_ids are returned.Testing
I have run exsisting tests