Skip to content

Renderer null check fix in solaraviz#2809

Merged
tpike3 merged 1 commit intomesa:mainfrom
Sahil-Chhoker:renderer-null-check-fix-in-solara
Jul 11, 2025
Merged

Renderer null check fix in solaraviz#2809
tpike3 merged 1 commit intomesa:mainfrom
Sahil-Chhoker:renderer-null-check-fix-in-solara

Conversation

@Sahil-Chhoker
Copy link
Copy Markdown
Collaborator

Explicity check if the renderer is None or not in SolaraViz.
Normal check was causing a error on the solara interface.

@Sahil-Chhoker Sahil-Chhoker requested a review from tpike3 July 10, 2025 05:47
@github-actions
Copy link
Copy Markdown

Performance benchmarks:

Model Size Init time [95% CI] Run time [95% CI]
BoltzmannWealth small 🔵 +1.6% [+0.8%, +2.5%] 🔵 -0.7% [-0.8%, -0.6%]
BoltzmannWealth large 🔵 +0.2% [-0.2%, +0.6%] 🔵 -0.9% [-2.2%, +0.4%]
Schelling small 🔵 -0.1% [-0.2%, +0.1%] 🔵 -0.3% [-0.4%, -0.1%]
Schelling large 🔵 -0.6% [-3.9%, +2.5%] 🔵 -1.8% [-2.4%, -1.2%]
WolfSheep small 🔵 -0.3% [-0.6%, -0.1%] 🔵 -0.5% [-0.6%, -0.3%]
WolfSheep large 🔵 -0.1% [-0.8%, +0.8%] 🔵 -0.7% [-1.4%, -0.1%]
BoidFlockers small 🔵 +0.7% [+0.3%, +1.1%] 🔵 +0.7% [+0.5%, +0.9%]
BoidFlockers large 🔵 +1.7% [+1.1%, +2.4%] 🔵 +1.2% [+0.9%, +1.6%]

Copy link
Copy Markdown
Member

@tpike3 tpike3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tpike3 tpike3 merged commit f9e6dbb into mesa:main Jul 11, 2025
13 checks passed
@tpike3 tpike3 added visualisation enhancement Release notes label labels Aug 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Release notes label visualisation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants