Skip to content

fix : prevent breakdown when citizen_density (Initial Agent Density s…#2806

Merged
tpike3 merged 1 commit intomesa:mainfrom
colinfrisch:fix_civil_violence
Jun 28, 2025
Merged

fix : prevent breakdown when citizen_density (Initial Agent Density s…#2806
tpike3 merged 1 commit intomesa:mainfrom
colinfrisch:fix_civil_violence

Conversation

@colinfrisch
Copy link
Copy Markdown
Member

@colinfrisch colinfrisch commented Jun 24, 2025

🐛 Bug fix

Noticed tiny bug on civil violence : the model breaks down when citizen_density (Initial Agent Density slider) is set to 0.
Fix is : model density starts now at 0.1

@colinfrisch colinfrisch added the bug Release notes label label Jun 24, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jun 24, 2025

Performance benchmarks:

Model Size Init time [95% CI] Run time [95% CI]
BoltzmannWealth small 🔵 +2.4% [+1.6%, +3.2%] 🔵 +0.4% [+0.2%, +0.5%]
BoltzmannWealth large 🔵 -0.3% [-0.7%, -0.0%] 🔵 -0.4% [-0.8%, -0.0%]
Schelling small 🔵 -0.0% [-0.2%, +0.1%] 🔵 -0.2% [-0.4%, -0.0%]
Schelling large 🔵 +0.7% [-0.8%, +3.0%] 🔵 +0.2% [-0.3%, +0.7%]
WolfSheep small 🔵 -0.3% [-0.5%, -0.1%] 🔵 +0.2% [-0.1%, +0.4%]
WolfSheep large 🔵 -0.6% [-1.2%, -0.3%] 🔵 +0.9% [+0.3%, +1.6%]
BoidFlockers small 🔵 +1.6% [+0.8%, +2.4%] 🔵 +0.3% [-0.1%, +0.6%]
BoidFlockers large 🔵 +1.7% [+1.0%, +2.3%] 🔵 +0.7% [+0.5%, +0.9%]

EwoutH
EwoutH approved these changes Jun 24, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@EwoutH EwoutH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting and fixing this, I think it makes sense.

I will leave the PR open for ~24 hours for additional comments/reviews.

tpike3
tpike3 approved these changes Jun 26, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@tpike3 tpike3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tpike3 tpike3 merged commit 7705e00 into mesa:main Jun 28, 2025
14 checks passed
@colinfrisch colinfrisch deleted the fix_civil_violence branch June 28, 2025 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@EwoutH EwoutH EwoutH approved these changes

@tpike3 tpike3 tpike3 approved these changes

Assignees

No one assigned

Labels

bug Release notes label

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@colinfrisch @EwoutH @tpike3