Skip to content

Bug fixes for portrayal components#2798

Merged
tpike3 merged 3 commits intomesa:mainfrom
Sahil-Chhoker:portrayal-bug-fixes
May 31, 2025
Merged

Bug fixes for portrayal components#2798
tpike3 merged 3 commits intomesa:mainfrom
Sahil-Chhoker:portrayal-bug-fixes

Conversation

@Sahil-Chhoker
Copy link
Copy Markdown
Collaborator

Summary

Fixes smaller bugs in mpl_space_drawing.py introduced by portrayal components.

Testing

Visualization tests were failing in PR #2767 due to edge cases, every test passes now.

@github-actions
Copy link
Copy Markdown

Performance benchmarks:

Model Size Init time [95% CI] Run time [95% CI]
BoltzmannWealth small 🔵 +0.9% [-0.3%, +2.2%] 🔵 -0.9% [-1.2%, -0.7%]
BoltzmannWealth large 🔵 +1.4% [+0.4%, +2.3%] 🔴 +9.3% [+5.6%, +13.6%]
Schelling small 🔵 +0.3% [+0.1%, +0.6%] 🔵 -0.7% [-1.1%, -0.3%]
Schelling large 🔵 +0.1% [-0.5%, +0.9%] 🔵 -2.9% [-4.9%, -0.8%]
WolfSheep small 🔵 +0.4% [+0.1%, +0.7%] 🔵 +0.3% [+0.1%, +0.5%]
WolfSheep large 🔵 -0.4% [-1.6%, +0.8%] 🔵 -0.7% [-2.6%, +1.1%]
BoidFlockers small 🔵 +1.6% [+0.6%, +2.9%] 🔵 +0.2% [+0.0%, +0.4%]
BoidFlockers large 🔵 +0.7% [+0.4%, +1.1%] 🔵 +0.6% [+0.3%, +0.8%]

@Sahil-Chhoker Sahil-Chhoker requested a review from quaquel May 29, 2025 10:12
@Sahil-Chhoker
Copy link
Copy Markdown
Collaborator Author

@tpike3 can you take a look at this PR?

Copy link
Copy Markdown
Member

@tpike3 tpike3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tpike3 tpike3 merged commit d1e6b8b into mesa:main May 31, 2025
12 checks passed
@tpike3 tpike3 added bug Release notes label visualisation labels Jun 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Release notes label visualisation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants