Skip to content

Feat: Added arrow key navigation#2725

Merged
tpike3 merged 3 commits intomesa:mainfrom
Sahil-Chhoker:feat-arrow-navigation-cc
Mar 23, 2025
Merged

Feat: Added arrow key navigation#2725
tpike3 merged 3 commits intomesa:mainfrom
Sahil-Chhoker:feat-arrow-navigation-cc

Conversation

@Sahil-Chhoker
Copy link
Copy Markdown
Collaborator

@Sahil-Chhoker Sahil-Chhoker commented Mar 18, 2025

This PR adds arrow key navigation (point 1 of issue #2705) in the CommandConsole.
A problem faced during the implementation of this feature was that we can't apply same event listener (keyup in my case) to multiple events. Issue for this is opened here.
Current fix I found was use all the available key related events, i.e., keypress for Enter, keyup for UpArrow, keydown for DownArrow. But the navigation works as expected.

@Sahil-Chhoker Sahil-Chhoker requested a review from quaquel March 18, 2025 09:42
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 18, 2025

Performance benchmarks:

Model Size Init time [95% CI] Run time [95% CI]
BoltzmannWealth small 🔵 +0.1% [-1.0%, +1.3%] 🔵 -0.8% [-0.9%, -0.6%]
BoltzmannWealth large 🔵 +16.4% [-0.2%, +51.7%] 🔵 -0.7% [-1.2%, -0.1%]
Schelling small 🔵 +0.3% [+0.1%, +0.5%] 🔵 -0.3% [-0.4%, -0.1%]
Schelling large 🔵 +0.7% [+0.2%, +1.2%] 🔵 +2.1% [-0.3%, +4.2%]
WolfSheep small 🔵 -0.1% [-0.3%, +0.2%] 🔵 -0.1% [-0.3%, +0.1%]
WolfSheep large 🔵 -0.0% [-0.7%, +0.6%] 🔵 +1.0% [+0.1%, +1.8%]
BoidFlockers small 🔵 -0.3% [-0.9%, +0.4%] 🔴 +4.2% [+3.9%, +4.6%]
BoidFlockers large 🔵 -0.4% [-1.0%, +0.2%] 🔴 +6.1% [+5.8%, +6.4%]

@Sahil-Chhoker Sahil-Chhoker requested a review from Corvince March 22, 2025 04:16
EwoutH
EwoutH approved these changes Mar 22, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@EwoutH EwoutH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean diff, useful feature. Thanks!

Final merge for another maintainer.

@tpike3 tpike3 merged commit e29fc80 into mesa:main Mar 23, 2025
11 checks passed
@tpike3
Copy link
Copy Markdown
Member

tpike3 commented Mar 23, 2025

Thanks @Sahil-Chhoker

@EwoutH EwoutH added feature Release notes label visualisation labels Apr 25, 2025
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 25, 2025

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@EwoutH EwoutH added enhancement Release notes label and removed feature Release notes label labels Apr 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@EwoutH EwoutH EwoutH approved these changes

@quaquel quaquel Awaiting requested review from quaquel

@Corvince Corvince Awaiting requested review from Corvince

Assignees

No one assigned

Labels

enhancement Release notes label visualisation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Sahil-Chhoker @tpike3 @EwoutH