paper: Add code examples and clarify terminology#2719
Merged
EwoutH merged 9 commits intomesa:paper_2024from Mar 14, 2025
Merged
paper: Add code examples and clarify terminology#2719EwoutH merged 9 commits intomesa:paper_2024from
EwoutH merged 9 commits intomesa:paper_2024from
Conversation
38941b5 to
2b10107
Compare
Member
Author
|
Thanks for reviewing! @quaquel are you good with the addition of the discrete and continuous terminology? |
quaquel
reviewed
Mar 14, 2025
quaquel
reviewed
Mar 14, 2025
quaquel
reviewed
Mar 14, 2025
Co-authored-by: Jan Kwakkel <[email protected]>
Member
Author
|
@quaquel thanks, it was a reviewer suggestion but I didn’t think it aligned with ABM terminology, like you confirmed. Thanks for the specific suggestions! |
EwoutH
commented
Mar 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements some last feedback from @jofmi and @martibosch on our JOSS paper for Mesa.
Each commit processes one feedback point:
Rendered paper (PDF).
Part of #2666.