Skip to content

Movable Input Field with auto-scroll#2710

Merged
quaquel merged 5 commits intomesa:mainfrom
Sahil-Chhoker:feat-input-cc
Mar 15, 2025
Merged

Movable Input Field with auto-scroll#2710
quaquel merged 5 commits intomesa:mainfrom
Sahil-Chhoker:feat-input-cc

Conversation

@Sahil-Chhoker
Copy link
Copy Markdown
Collaborator

@Sahil-Chhoker Sahil-Chhoker commented Mar 8, 2025 •
edited
Loading

Making a component out of the input field and adjusts the input field according to the contents of history shown and uses solara.v.ScrollYTransition() for auto scrolling when input field is changed.

This is the feature development for issue #2705, second and fifth points.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 8, 2025

Performance benchmarks:

Model Size Init time [95% CI] Run time [95% CI]
BoltzmannWealth small 🔴 +3.7% [+3.3%, +4.2%] 🔵 +3.3% [+3.0%, +3.6%]
BoltzmannWealth large 🔵 +0.2% [-0.3%, +0.7%] 🔵 +1.1% [+0.9%, +1.3%]
Schelling small 🔵 +0.7% [+0.4%, +0.9%] 🔵 -0.1% [-0.4%, +0.2%]
Schelling large 🔵 +0.5% [-0.0%, +0.9%] 🔵 +1.8% [+0.7%, +3.1%]
WolfSheep small 🔵 -0.7% [-0.9%, -0.5%] 🔵 +0.1% [-0.1%, +0.2%]
WolfSheep large 🔵 -0.5% [-0.7%, -0.3%] 🔵 +0.6% [+0.3%, +0.8%]
BoidFlockers small 🔵 -0.4% [-1.0%, +0.2%] 🔵 +2.2% [+2.1%, +2.4%]
BoidFlockers large 🔵 -1.4% [-2.0%, -0.9%] 🔵 +1.3% [+1.1%, +1.6%]

@quaquel
Copy link
Copy Markdown
Member

quaquel commented Mar 10, 2025

Nice, I'll try to check it tonight.

One suggestion: can you add the console to one of the advanced examples? This makes it easier to locally play arround with it as well as provide an illustration to other how to add the console to their models.

@quaquel
Copy link
Copy Markdown
Member

quaquel commented Mar 11, 2025 •
edited
Loading

Great stuff! Works as expected

one minor thing: the tips hint is tied to the movable input field. Perhaps move it to underneath "Command Console"?

@Sahil-Chhoker
Copy link
Copy Markdown
Collaborator Author

Sahil-Chhoker commented Mar 11, 2025

one minor thing: the tips hint is tied to the movable input field. Perhaps move it to underneath "Command Console"?

Done!

@quaquel quaquel merged commit bca742f into mesa:main Mar 15, 2025
11 checks passed
@EwoutH EwoutH added enhancement Release notes label visualisation labels Apr 25, 2025
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 25, 2025

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@quaquel quaquel quaquel approved these changes

@Corvince Corvince Awaiting requested review from Corvince

Assignees

No one assigned

Labels

enhancement Release notes label visualisation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Sahil-Chhoker @quaquel @EwoutH