Skip to content

Move Game of life to cell space#2681

Merged
quaquel merged 6 commits intomesa:mainfrom
quaquel:game_of_life
Feb 13, 2025
Merged

Move Game of life to cell space#2681
quaquel merged 6 commits intomesa:mainfrom
quaquel:game_of_life

Conversation

@quaquel
Copy link
Copy Markdown
Member

@quaquel quaquel commented Feb 11, 2025

This moves game of life over to use cell spaces.

@quaquel quaquel requested a review from EwoutH February 11, 2025 18:35
@quaquel quaquel added the example Changes the examples or adds to them. label Feb 11, 2025
@quaquel quaquel added the trigger-benchmarks Special label that triggers the benchmarking CI label Feb 12, 2025
@EwoutH EwoutH mentioned this pull request Feb 12, 2025
Merged
@quaquel quaquel added trigger-benchmarks Special label that triggers the benchmarking CI and removed trigger-benchmarks Special label that triggers the benchmarking CI labels Feb 13, 2025
@EwoutH
Copy link
Copy Markdown
Member

EwoutH commented Feb 13, 2025

Game of Life isn’t in the benchmark models. Why did the performance benchmark fail in this PR?

@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 13, 2025

Performance benchmarks:

Model Size Init time [95% CI] Run time [95% CI]
BoltzmannWealth small 🔵 -0.4% [-1.1%, +0.3%] 🔵 -0.7% [-0.8%, -0.5%]
BoltzmannWealth large 🔵 -1.1% [-1.9%, -0.3%] 🔵 -0.7% [-2.3%, +0.9%]
Schelling small 🔵 +0.7% [+0.4%, +0.9%] 🔵 -1.6% [-1.8%, -1.4%]
Schelling large 🔵 +0.4% [-0.1%, +0.9%] 🔵 -0.3% [-1.1%, +0.5%]
WolfSheep small 🔵 +1.4% [+1.1%, +1.6%] 🔵 -0.7% [-1.0%, -0.4%]
WolfSheep large 🔵 +2.5% [+1.4%, +3.8%] 🔵 +1.9% [+1.2%, +2.7%]
BoidFlockers small 🔵 +1.7% [+0.9%, +2.4%] 🔵 +2.4% [+2.2%, +2.7%]
BoidFlockers large 🔵 +2.0% [+1.6%, +2.4%] 🔵 +1.7% [+1.5%, +1.9%]

@quaquel quaquel removed the trigger-benchmarks Special label that triggers the benchmarking CI label Feb 13, 2025
@quaquel
Copy link
Copy Markdown
Member Author

quaquel commented Feb 13, 2025

Game of Life isn’t in the benchmark models. Why did the performance benchmark fail in this PR?

Because of the __init__.py issue fixed in #2687. As you can see, it now passes.

@quaquel quaquel merged commit 380c6ad into mesa:main Feb 13, 2025
9 of 10 checks passed
@quaquel quaquel deleted the game_of_life branch February 15, 2025 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@EwoutH EwoutH EwoutH approved these changes

Assignees

No one assigned

Labels

example Changes the examples or adds to them.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@quaquel @EwoutH