Skip to content

paper: Clearly mark experimental features#2675

Merged
EwoutH merged 2 commits intomesa:paper_2024from
EwoutH:mark_experimental
Feb 10, 2025
Merged

paper: Clearly mark experimental features#2675
EwoutH merged 2 commits intomesa:paper_2024from
EwoutH:mark_experimental

Conversation

@EwoutH
Copy link
Copy Markdown
Member

@EwoutH EwoutH commented Feb 9, 2025

Clearly mark Mesa's experimental features in the JOSS paper.

Part of #2666. @jofmi, please let me know if you consider this enough to address your feedback.

@EwoutH EwoutH requested review from jackiekazil and quaquel February 9, 2025 09:32
@EwoutH EwoutH mentioned this pull request Feb 9, 2025
41 tasks
Copy link
Copy Markdown
Member

@quaquel quaquel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one minor suggestion, but fine otherwisel.

@EwoutH
Copy link
Copy Markdown
Member Author

EwoutH commented Feb 9, 2025

Thanks! Let's see what @jofmi thinks of it.

@jofmi
Copy link
Copy Markdown

jofmi commented Feb 10, 2025

Thanks! Two more points from my side

  • This only covers the time-section, what about the experimental space section? will it be marked as not experimental anymore because it is stable (I think you mentioned that somewhere else?)
  • Please extend the documentation to have at least the same information about these features in the docs as in the paper, ideally of course a bit more details :)

@quaquel
Copy link
Copy Markdown
Member

quaquel commented Feb 10, 2025

cell spaces will be stable in 3.2 (the PR has already been approved and will be merged somehwere this week)

@EwoutH
Copy link
Copy Markdown
Member Author

EwoutH commented Feb 10, 2025

Thanks! Your first point was addressed by quaquel, as for the second, this should be addressed in:

@jofmi
Copy link
Copy Markdown

jofmi commented Feb 10, 2025

Great thanks, then you would just need to change that one part of the paper where it says that cell spaces is experimental :)

@EwoutH EwoutH merged commit f2df946 into mesa:paper_2024 Feb 10, 2025
1 check passed
@EwoutH EwoutH deleted the mark_experimental branch February 10, 2025 18:54
@EwoutH
Copy link
Copy Markdown
Member Author

EwoutH commented Feb 10, 2025

you would just need to change that one part of the paper where it says that cell spaces is experimental :)

@quaquel could you check this?

1 similar comment
@EwoutH
Copy link
Copy Markdown
Member Author

EwoutH commented Feb 10, 2025

you would just need to change that one part of the paper where it says that cell spaces is experimental :)

@quaquel could you check this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants