Merged
Conversation
|
Performance benchmarks:
|
Member
|
@Sahil-Chhoker since you put in the original issue, would you like to review? |
Collaborator
|
@EwoutH Sure, I would love to! |
Sahil-Chhoker
requested changes
Jan 23, 2025
|
|
||
| data = layer.data.astype(float) if layer.data.dtype == bool else layer.data | ||
| width, height = data.shape # if space is None else (space.width, space.height) | ||
|
|
Collaborator
There was a problem hiding this comment.
I would suggest adding these two lines:
data = data.T
height, width = data.shape
Member
Author
There was a problem hiding this comment.
I fixed your comments in a slightly different way but the effect is the same
Collaborator
|
This was a fairly simple fix, @EwoutH this PR can be merged! |
EwoutH
approved these changes
Jan 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This closes #2635. Axes.imshow uses row, col, while our property layer data is x, y. This solves this by transposing the data in the axes.imshow command.