Conversation
EwoutH
approved these changes
Jan 10, 2025
tpike3
pushed a commit
to tpike3/mesa
that referenced
this pull request
Mar 25, 2025
* reimplementation of draw_voroinoi * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reimplements
draw_voroinoiand makes it behave identically todraw_hexgrids. This, therefore, removescell_coloring_propertyfrom the Voronoi grid. It also adds thedraw_gridboolean todraw_voroinoiwhich is also available for all other discrete spaces.Any future work on further developing the API for controlling how to draw a space itself such as #2438 and #2557, now at least can start from an underlying consistent code base.
Before
After
Closes #2437 and #2549