cell_space: Allow CellCollection to be empty#2502
Merged
Conversation
Sometimes it's useful to have any empty cell collection in the cell space, which can happen after selection with no cells that meet the selection requirements. However, self._capacity would give an error, because there were no cell to derive the capacity from. This PR resolves that error.
|
Performance benchmarks:
|
quaquel
reviewed
Nov 13, 2024
quaquel
approved these changes
Nov 13, 2024
EwoutH
added a commit
that referenced
this pull request
Nov 13, 2024
Sometimes it's useful to have any empty cell collection in the cell space, which can happen after selection with no cells that meet the selection requirements. However, self._capacity would give an error, because there were no cell to derive the capacity from. This PR resolves that error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes a CellCollection needs to be empty, especially after filtering with
.select(). However, the code would raise a StopIteration error trying to getcapacityfrom the first cell. This PR handles empty collections gracefully.Summary
Fix StopIteration error when creating empty CellCollections by allowing
capacityto be None when there are no cells.Bug / Issue
Creating a CellCollection with no cells (after filtering) raises StopIteration:
Implementation
Check for empty collection before accessing first cell's capacity:
Testing