Skip to content

space: Add note that Grids are maintenance only#2420

Merged
EwoutH merged 2 commits intomainfrom
grid_maintenance_note
Oct 25, 2024
Merged

space: Add note that Grids are maintenance only#2420
EwoutH merged 2 commits intomainfrom
grid_maintenance_note

Conversation

@EwoutH
Copy link
Copy Markdown
Member

@EwoutH EwoutH commented Oct 25, 2024 •
edited
Loading

Add a note to the space module level docstring that the Grids are maintenance only.

Also add the PropertyLayer to the classes and remove the Grid, since that's now private (and has been for a while).

Now looks like this:
image

@EwoutH
space: Add note that Grids are maintenance only
b01cbb0 
Add a note to the space module level docstring that the Grids are maintenance only.

Also add the PropertyLayer to the classes and remove the Grid, since that's now private (and has been for a while).
@EwoutH EwoutH added the docs Release notes label label Oct 25, 2024
@EwoutH EwoutH added this to the v3.0 milestone Oct 25, 2024
@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 25, 2024

Performance benchmarks:

Model Size Init time [95% CI] Run time [95% CI]
BoltzmannWealth small 🔵 -2.3% [-3.6%, -0.9%] 🔵 +1.0% [+0.7%, +1.3%]
BoltzmannWealth large 🔵 +0.0% [-0.6%, +0.8%] 🔵 +4.2% [+2.6%, +5.6%]
Schelling small 🔵 -0.3% [-0.8%, +0.1%] 🔵 +0.3% [+0.0%, +0.5%]
Schelling large 🔵 -0.9% [-2.2%, +0.2%] 🔵 -1.0% [-3.2%, +1.1%]
WolfSheep small 🔵 +0.1% [-0.2%, +0.3%] 🔵 +0.3% [+0.2%, +0.5%]
WolfSheep large 🔵 +0.7% [+0.3%, +1.1%] 🔵 +1.9% [+1.0%, +2.7%]
BoidFlockers small 🔵 +1.0% [+0.4%, +1.7%] 🔵 +0.2% [-0.4%, +0.9%]
BoidFlockers large 🔵 +0.7% [+0.4%, +1.1%] 🔵 +0.4% [-0.4%, +1.2%]

@EwoutH EwoutH requested a review from quaquel October 25, 2024 10:37
@EwoutH EwoutH marked this pull request as ready for review October 25, 2024 10:37
@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 25, 2024

Performance benchmarks:

Model Size Init time [95% CI] Run time [95% CI]
BoltzmannWealth small 🔵 -1.0% [-2.5%, +0.5%] 🔵 -0.9% [-1.1%, -0.7%]
BoltzmannWealth large 🔵 -1.1% [-1.5%, -0.7%] 🔵 -0.3% [-1.3%, +0.7%]
Schelling small 🔵 +0.4% [+0.1%, +0.7%] 🔵 -0.2% [-0.4%, -0.0%]
Schelling large 🔵 +1.4% [+0.3%, +2.4%] 🔵 +0.0% [-1.4%, +1.4%]
WolfSheep small 🔵 +1.1% [+0.8%, +1.5%] 🔵 -0.7% [-0.9%, -0.5%]
WolfSheep large 🔵 +1.3% [+0.9%, +1.6%] 🔵 +0.7% [-0.2%, +1.6%]
BoidFlockers small 🔵 +0.2% [-0.3%, +0.7%] 🔵 -0.9% [-1.7%, -0.2%]
BoidFlockers large 🔵 -0.0% [-0.6%, +0.6%] 🔵 +0.0% [-0.6%, +0.8%]

tpike3
tpike3 approved these changes Oct 25, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@tpike3 tpike3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@quaquel
Copy link
Copy Markdown
Member

quaquel commented Oct 25, 2024

indeed go ahead and merge it.

One thing I noted but can be done in a separate: remove HexGrid from mesa.space. It has been deprecated already so it can be safely removed.

@EwoutH EwoutH merged commit 4215706 into main Oct 25, 2024
@EwoutH EwoutH deleted the grid_maintenance_note branch October 26, 2024 13:22
@EwoutH EwoutH mentioned this pull request Nov 25, 2024
Closed
21 tasks
This was referenced Jan 7, 2026
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@quaquel quaquel quaquel approved these changes

@tpike3 tpike3 tpike3 approved these changes

Assignees

No one assigned

Labels

docs Release notes label

Projects

None yet

Milestone

v3.0

Development

Successfully merging this pull request may close these issues.

3 participants

@EwoutH @quaquel @tpike3