examples: Clean-up Epstein Civil Violence and PD grid by EwoutH · Pull Request #2373 · mesa/mesa

EwoutH · 2024-10-16T12:25:13Z

Clean up the epstein civil voilence models.

One issue is that a deepcopy currently isn't possible, and Solara currently uses that.

model1 = EpsteinCivilViolence()
import copy
# make deepcopy
model2 = copy.deepcopy(model1)

@quaquel would you like to pick this further up?

github-actions · 2024-10-16T12:31:17Z

Performance benchmarks:

Model	Size	Init time [95% CI]	Run time [95% CI]
BoltzmannWealth	small	🟢 -16.1% [-17.5%, -14.6%]	🔵 +0.2% [+0.0%, +0.3%]
BoltzmannWealth	large	🔵 +2.1% [+1.6%, +2.6%]	🔵 +1.4% [+0.7%, +2.1%]
Schelling	small	🔵 -1.8% [-2.4%, -1.2%]	🔵 -0.6% [-0.8%, -0.4%]
Schelling	large	🔵 -0.9% [-2.4%, +0.5%]	🔵 +0.0% [-1.9%, +2.5%]
WolfSheep	small	🔵 -0.7% [-1.0%, -0.3%]	🔵 +1.1% [+0.8%, +1.3%]
WolfSheep	large	🔵 +1.4% [-0.2%, +2.9%]	🔴 +7.1% [+4.8%, +9.6%]
BoidFlockers	small	🔵 -3.2% [-3.5%, -2.9%]	🔵 +0.6% [-0.2%, +1.3%]
BoidFlockers	large	🔵 -0.5% [-1.4%, +0.2%]	🔵 +1.2% [+0.6%, +1.8%]

…/mesa into examples_advanced_updates

quaquel · 2024-10-16T13:48:30Z

This is a properly obscure problem. It arises from trying to deepcopy the OrthogonalMooreSpace. Even worse, whether or not the error triggers depends on the size of the grid (which suggests to me that perhaps recurssion error is triggered to early?). See also here

To test this yourself, try to deepcopy a moore / von neumann grid with varying sizes and see when it errrors out.

My hunch is that the problem starts from Cell.connections. If I comment out self.connections[key] = other in Cell.connect the problem disappears, supporting my hunch. One solution is to implement __setstate__ and __getstate__ explicitly for both Cell and Grid. Basically, don't return Cell.connections, and in Grid.__setstate__ after having initialized everything, rebuild the connections explicitly.

This is a major bug because it means that large experimental grids are currently not pickleable....

@Corvince any thoughts?

for more information, see https://pre-commit.ci

quaquel · 2024-10-16T14:44:18Z

I have committed a possible fix in line with my previous comment. In short, In Cell.__getstate__, I set "connections" to an empty dict. In DiscreteSpace.__setstate__, I rebuild the connections via DiscreteSpace._connect_cells(). This latter method already existed in Grid and Voronoi, but not yet in network. I have thus moved the method stub to DiscreteSpace and implemented it for Network.

It needs further testing and additional unit tests for all DiscreteSpaces and large sizes, but it seems to work.

~~Also, this is a fix for Grids, not sure if the problem is present in all Discrete spaces....~~

for more information, see https://pre-commit.ci

EwoutH · 2024-10-16T16:45:02Z

Thanks! I will continue updating the examples, if this works for all of them than we can include this in a separate PR.

quaquel · 2024-10-16T16:46:36Z

Thanks! I will continue updating the examples, if this works for all of them than we can include this in a separate PR.

Ok, I'll move the fix into a separate PR and add additional unit tests. Let me know how you get on with the other examples.

- Flatten structure - Completely rewrite SolaraViz - Cleanup and update docs

EwoutH · 2024-10-16T17:47:58Z

Awesome!

Updated pd_grid (Demographic Prisoner's Dilemma on a Grid). One issue is that we can't visualize any of the cell spaces currently. Without that the visualisations are quite useless. Tracking issue here:

Visualize Cell Space #2377

quaquel · 2024-10-18T14:21:04Z

I guess it would make sense to merge this even if #2377 is not addressed yet. It means the docs can progress and would give us something to use when developing #2377.

github-actions · 2024-10-18T14:30:49Z

Performance benchmarks:

Model	Size	Init time [95% CI]	Run time [95% CI]
BoltzmannWealth	small	🟢 -8.1% [-9.4%, -6.6%]	🔵 -0.9% [-1.1%, -0.6%]
BoltzmannWealth	large	🔵 +0.2% [-0.1%, +0.4%]	🔵 -3.6% [-4.8%, -2.4%]
Schelling	small	🔵 -0.8% [-1.1%, -0.4%]	🔵 +0.1% [-0.1%, +0.3%]
Schelling	large	🔵 +0.4% [-0.4%, +1.3%]	🔵 +1.1% [-1.5%, +4.1%]
WolfSheep	small	🔵 +0.7% [+0.5%, +0.9%]	🔵 -0.2% [-0.4%, -0.0%]
WolfSheep	large	🔵 +0.1% [-0.9%, +0.9%]	🔵 -1.6% [-3.3%, +0.2%]
BoidFlockers	small	🔵 -2.1% [-2.8%, -1.4%]	🔵 -0.2% [-0.8%, +0.5%]
BoidFlockers	large	🔵 -1.1% [-1.6%, -0.6%]	🔵 -0.8% [-1.2%, -0.2%]

quaquel · 2024-10-18T16:13:59Z

What's there is, is good. Would it make sense to remove the notebooks?

EwoutH · 2024-10-21T07:40:04Z

This merge conflict, fuck.... couldn't we have merged this before the examples move?

quaquel · 2024-10-21T07:47:29Z

Yep the merge conflict is massive (as with the docs stuff). Might be better to start a new branch and copy these changes into it (As you are doing with docs atm).

quaquel · 2024-10-23T09:28:56Z

Do you mind if I pick this up as a new PR given the rebase/merge mess? I have time this afternoon (Wednesday 23 October) for simple cleanup work (but not for figuring out complicated stuff like the solara run import problem).

quaquel · 2024-10-24T06:17:30Z

Superseded by #2408

examples: Clean-up Epstein Civil Violence

79e85f6

examples: Clean-up Epstein Civil Violence

a827a5d

EwoutH force-pushed the examples_advanced_updates branch from 79e85f6 to a827a5d Compare October 16, 2024 12:40

Merge branch 'examples_advanced_updates' of https://github.com/EwoutH…

81af0ac

…/mesa into examples_advanced_updates

quaquel added the bug Release notes label label Oct 16, 2024

quaquel and others added 2 commits October 16, 2024 16:42

bug fix

b118643

[pre-commit.ci] auto fixes from pre-commit.com hooks

3f91d73

for more information, see https://pre-commit.ci

quaquel and others added 3 commits October 16, 2024 16:44

Merge branch 'main' into examples_advanced_updates

fb627f1

generalize fix to all discrete spaces

1a51c15

[pre-commit.ci] auto fixes from pre-commit.com hooks

4d6e6a9

for more information, see https://pre-commit.ci

EwoutH added 3 commits October 16, 2024 19:41

Fix pre-commit by adding docstring

9df39e5

examples/pd_grid: Cleanup and refactor

570539b

- Flatten structure - Completely rewrite SolaraViz - Cleanup and update docs

examples/pd_grid: Clean up analysis notebook

4f51c0e

examples/epstein: Uncomment model again

d250270

quaquel mentioned this pull request Oct 16, 2024

Bugfix for deepcopy / pickling discrete spaces #2378

Merged

Merge branch 'main' into examples_advanced_updates

1f75630

EwoutH marked this pull request as ready for review October 18, 2024 14:24

EwoutH changed the title ~~examples: Clean-up Epstein Civil Violence~~ examples: Clean-up Epstein Civil Violence and PD grid Oct 18, 2024

EwoutH added example Changes the examples or adds to them. and removed bug Release notes label labels Oct 18, 2024

quaquel closed this Oct 24, 2024

Uh oh!

Conversation

EwoutH commented Oct 16, 2024

Uh oh!

github-actions bot commented Oct 16, 2024

Uh oh!

quaquel commented Oct 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

quaquel commented Oct 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

EwoutH commented Oct 16, 2024

Uh oh!

quaquel commented Oct 16, 2024

Uh oh!

EwoutH commented Oct 16, 2024

Uh oh!

quaquel commented Oct 18, 2024

Uh oh!

github-actions bot commented Oct 18, 2024

Uh oh!

quaquel commented Oct 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

EwoutH commented Oct 21, 2024

Uh oh!

quaquel commented Oct 21, 2024

Uh oh!

quaquel commented Oct 23, 2024

Uh oh!

quaquel commented Oct 24, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

quaquel commented Oct 16, 2024 •

edited

Loading

quaquel commented Oct 16, 2024 •

edited

Loading

quaquel commented Oct 18, 2024 •

edited

Loading