experimental init: Fix Solara import by making it lazy#2357
Merged
experimental init: Fix Solara import by making it lazy#2357
Conversation
|
Performance benchmarks:
|
quaquel
approved these changes
Oct 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the experimental
__init__.py, it always tries to import the "old" solara_viz module, even if it's not needed because only the cell space is used. This PR wraps that in a try block to also allow using the experimental cell space without Solara installed.Quick and dirty fix for #2343, follow up after #2265, unblocks mesa/mesa-examples#198.