Skip to content

Update to CellCollection.select#2307

Merged
quaquel merged 6 commits intomesa:mainfrom
quaquel:cellcollection
Sep 21, 2024
Merged

Update to CellCollection.select#2307
quaquel merged 6 commits intomesa:mainfrom
quaquel:cellcollection

Conversation

@quaquel
Copy link
Copy Markdown
Member

@quaquel quaquel commented Sep 21, 2024

This PR updates CellCollect.select to reflect the updated API of AgentSet.select. So, we switch to at_most instead of using n. Since n was not used anyway before and this is still experimental, I have just removed n altogether.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 21, 2024

Performance benchmarks:

Model Size Init time [95% CI] Run time [95% CI]
BoltzmannWealth small 🟢 -4.3% [-5.1%, -3.5%] 🔴 +8.5% [+8.3%, +8.7%]
BoltzmannWealth large 🔵 -2.0% [-2.5%, -1.4%] 🔴 +16.0% [+11.7%, +21.6%]
Schelling small 🔵 -0.0% [-0.5%, +0.4%] 🔵 +0.6% [+0.4%, +0.9%]
Schelling large 🔵 -0.1% [-0.9%, +0.5%] 🔵 +1.5% [-0.6%, +3.8%]
WolfSheep small 🔵 +0.0% [-0.4%, +0.4%] 🔵 +2.9% [-0.3%, +6.2%]
WolfSheep large 🔵 +1.0% [-0.2%, +2.2%] 🔴 +6.6% [+4.8%, +8.4%]
BoidFlockers small 🔵 +0.2% [-0.2%, +0.6%] 🔵 -0.3% [-1.0%, +0.4%]
BoidFlockers large 🔵 -0.0% [-0.5%, +0.4%] 🔵 -0.6% [-1.1%, -0.1%]

@quaquel
Copy link
Copy Markdown
Member Author

quaquel commented Sep 21, 2024

these performance benchmarks are strange. Neither one uses CellCollection.select.

@quaquel quaquel marked this pull request as ready for review September 21, 2024 08:29
@quaquel quaquel requested a review from Corvince September 21, 2024 08:29
@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 21, 2024

Performance benchmarks:

Model Size Init time [95% CI] Run time [95% CI]
BoltzmannWealth small 🔵 -3.5% [-4.6%, -2.5%] 🔵 +0.4% [+0.2%, +0.6%]
BoltzmannWealth large 🔵 -1.3% [-1.6%, -0.9%] 🔵 -0.2% [-1.3%, +1.0%]
Schelling small 🔵 -3.3% [-3.7%, -2.9%] 🔵 -0.1% [-0.4%, +0.2%]
Schelling large 🟢 -5.6% [-6.0%, -5.2%] 🟢 -12.5% [-13.4%, -11.8%]
WolfSheep small 🟢 -3.4% [-3.7%, -3.2%] 🔵 -1.0% [-1.2%, -0.8%]
WolfSheep large 🟢 -6.3% [-7.5%, -5.3%] 🟢 -11.5% [-12.4%, -10.7%]
BoidFlockers small 🟢 -4.2% [-4.6%, -3.7%] 🔵 -1.4% [-1.9%, -0.8%]
BoidFlockers large 🔵 -3.1% [-3.7%, -2.6%] 🔵 -1.3% [-1.9%, -0.6%]

@quaquel quaquel mentioned this pull request Sep 21, 2024
Closed
9 tasks
@EwoutH
Copy link
Copy Markdown
Member

EwoutH commented Sep 21, 2024

Nice to align them. Reminds me I wanted to add a sample method.

We merged some stuff, I think that's causing this PR branch to have more differences with main. Maybe rebase it.

@EwoutH EwoutH added the enhancement Release notes label label Sep 21, 2024
@quaquel quaquel merged commit 56117dc into mesa:main Sep 21, 2024
@EwoutH EwoutH added the experimental Release notes label label Sep 21, 2024
@EwoutH EwoutH mentioned this pull request Sep 21, 2024
Merged
@quaquel quaquel deleted the cellcollection branch October 13, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Corvince Corvince Corvince approved these changes

@EwoutH EwoutH EwoutH approved these changes

Assignees

No one assigned

Labels

enhancement Release notes label experimental Release notes label

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@quaquel @EwoutH @Corvince