Skip to content

fix: Use model.schedule.steps -> mode._steps for batch_run#2183

Merged
rht merged 1 commit intomesa:mainfrom
rht:fix_batch_run
Jul 21, 2024
Merged

fix: Use model.schedule.steps -> mode._steps for batch_run#2183
rht merged 1 commit intomesa:mainfrom
rht:fix_batch_run

Conversation

@rht
Copy link
Copy Markdown
Contributor

@rht rht commented Jul 21, 2024

@rht rht mentioned this pull request Jul 21, 2024
Closed
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jul 21, 2024

Performance benchmarks:

Model Size Init time [95% CI] Run time [95% CI]
Schelling small 🔵 -0.0% [-0.3%, +0.3%] 🔵 -0.8% [-1.0%, -0.6%]
Schelling large 🔵 -0.0% [-0.5%, +0.5%] 🔵 +0.6% [-1.8%, +3.2%]
WolfSheep small 🔵 +0.9% [-0.0%, +1.8%] 🔵 +1.7% [+1.4%, +2.0%]
WolfSheep large 🔵 +0.5% [+0.0%, +1.2%] 🔵 +2.0% [-0.8%, +5.0%]
BoidFlockers small 🔵 -0.2% [-1.0%, +0.5%] 🔵 -0.1% [-0.9%, +0.6%]
BoidFlockers large 🔵 +0.0% [-0.8%, +0.9%] 🔵 -0.3% [-0.9%, +0.4%]

EwoutH
EwoutH approved these changes Jul 21, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@EwoutH EwoutH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

Should we add a test case for this somewhere? Or add an example model to the CI that uses this?

@EwoutH EwoutH mentioned this pull request Jul 21, 2024
Open
@EwoutH EwoutH added the bug Release notes label label Jul 21, 2024
@EwoutH
Copy link
Copy Markdown
Member

EwoutH commented Jul 21, 2024 •
edited
Loading

@dylan-munson, could you install this branch and confirm it fixes your issue?

pip install -U -e git+https://github.com/rht/mesa@fix_batch_run#egg=mesa

@dylan-munson
Copy link
Copy Markdown

dylan-munson commented Jul 21, 2024

Hi, I tried running the pip install command but received an error message that git checkout -q fix_batch_run did not run successfully, so I am unable to try.

@dylan-munson
Copy link
Copy Markdown

dylan-munson commented Jul 21, 2024

Sorry, I made a mistake somewhere and was actually able to install. This did indeed fix the problem, thank you!

@rht
Copy link
Copy Markdown
Contributor Author

rht commented Jul 21, 2024

I will add a test case when I have the time. For now, this is a hotfix so that people's batch_run is back to be running again.

@rht
Copy link
Copy Markdown
Contributor Author

rht commented Jul 21, 2024

Sorry, I made a mistake somewhere and was actually able to install. This did indeed fix the problem, thank you!

@dylan-munson thank you for testing.

@rht rht merged commit 01477fc into mesa:main Jul 21, 2024
@rht rht deleted the fix_batch_run branch July 21, 2024 20:38
@EwoutH
Copy link
Copy Markdown
Member

EwoutH commented Jul 21, 2024

Do we need a backport to 2.3 branch and a new 2.3.x. patch release?

@rht
Copy link
Copy Markdown
Contributor Author

rht commented Jul 21, 2024

Ah, right, for 2.3.x only, since the _steps is new since 2.3.0.

@EwoutH EwoutH mentioned this pull request Jul 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@EwoutH EwoutH EwoutH approved these changes

Assignees

No one assigned

Labels

bug Release notes label

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rht @EwoutH @dylan-munson