Skip to content

test: Remove place_agent duplicate warnings#2086

Merged
rht merged 1 commit intomesa:mainfrom
rht:fix_test
Mar 24, 2024
Merged

test: Remove place_agent duplicate warnings#2086
rht merged 1 commit intomesa:mainfrom
rht:fix_test

Conversation

@rht
Copy link
Copy Markdown
Contributor

@rht rht commented Mar 24, 2024

Because of #2083, some faulty test code have been caught. cc: @puer-robustus

@rht rht force-pushed the fix_test branch 2 times, most recently from df54bbe to 8267299 Compare March 24, 2024 00:14
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 24, 2024

Performance benchmarks:

Model Size Init time [95% CI] Run time [95% CI]
Schelling small 🔵 +0.0% [-0.3%, +0.4%] 🔵 -0.1% [-0.3%, +0.1%]
Schelling large 🔵 -0.2% [-0.8%, +0.3%] 🔵 +0.6% [+0.2%, +0.9%]
WolfSheep small 🔵 +0.1% [-0.7%, +0.9%] 🔵 +0.1% [-0.2%, +0.3%]
WolfSheep large 🔵 -0.1% [-0.5%, +0.2%] 🔵 -0.3% [-0.5%, -0.1%]
BoidFlockers small 🔵 +0.1% [-0.4%, +0.7%] 🔵 +0.7% [+0.1%, +1.4%]
BoidFlockers large 🔵 +0.6% [+0.3%, +0.9%] 🔵 +1.1% [+0.6%, +1.6%]

@EwoutH
Copy link
Copy Markdown
Member

EwoutH commented Mar 24, 2024

Can you split of the ruff update in a separate PR? I like to keep PRs atomic.

@rht
Copy link
Copy Markdown
Contributor Author

rht commented Mar 24, 2024

Done.

@EwoutH
Copy link
Copy Markdown
Member

EwoutH commented Mar 24, 2024 •
edited
Loading

Thanks! I guess it isn’t allowed in current Mesa to initialize agents with a pos right? I have seen it in other models, maybe we should write that up somewhere.

Also, which warning is this removing exactly?

@rht rht added trigger-benchmarks Special label that triggers the benchmarking CI and removed trigger-benchmarks Special label that triggers the benchmarking CI labels Mar 24, 2024
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 24, 2024

Performance benchmarks:

Model Size Init time [95% CI] Run time [95% CI]
Schelling small 🔵 +0.1% [-0.1%, +0.3%] 🔵 +0.5% [+0.4%, +0.7%]
Schelling large 🔵 -0.0% [-0.4%, +0.5%] 🔵 +0.2% [-0.2%, +0.9%]
WolfSheep small 🔵 +0.7% [-0.3%, +1.7%] 🔵 +1.2% [+1.1%, +1.4%]
WolfSheep large 🔵 -0.0% [-0.4%, +0.4%] 🔵 +1.7% [+1.3%, +2.1%]
BoidFlockers small 🟢 -88.0% [-88.1%, -87.9%] 🔵 -2.7% [-3.4%, -2.0%]
BoidFlockers large 🟢 -87.9% [-88.0%, -87.9%] 🔵 -1.5% [-2.1%, -0.8%]

@rht
Copy link
Copy Markdown
Contributor Author

rht commented Mar 24, 2024

Thanks! I guess it isn’t allowed in current Mesa to initialize agents with a pos right?

Allowed but not recommended.

Also, which warning is this removing exactly?

#2083

@rht rht mentioned this pull request Mar 24, 2024
Merged
@rht rht merged commit 4eef2be into mesa:main Mar 24, 2024
@EwoutH EwoutH added the testing Release notes label label Apr 18, 2024
@rht rht mentioned this pull request Jul 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@EwoutH EwoutH EwoutH approved these changes

Assignees

No one assigned

Labels

testing Release notes label

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rht @EwoutH