Conversation
|
Performance benchmarks:
|
Member
|
Can you explain why you are concerned about CI testing time? |
Contributor
Author
|
Member
|
Fair enough, although this does not make a massive difference for me. I always think of this in a more categorical manner: can I wait behind my desk, can I go for a cup of coffee, can it run over lunch, or does it take even longer? The difference between 30 seconds and 2 minutes is still very much in the behind-my-desk category. Also, I see CI stuff as stuff that runs after having tested everything locally anyway, so I don't really see the feedback loop argument. To be clear: speedups are still nice. |
EwoutH
approved these changes
Feb 16, 2024
Member
EwoutH
left a comment
EwoutH
left a comment
There was a problem hiding this comment.
I don't see significant degradation in test functionality, so looks good. Faster CI is always nice, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an attempt to speed up overall CI testing time, as much as possible without reducing comprehensiveness. Currently, it takes 12s on Python 3.12 on Ubuntu.