Conversation
Closed
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1854 +/- ##
==========================================
- Coverage 81.38% 77.42% -3.97%
==========================================
Files 15 15
Lines 881 970 +89
Branches 186 213 +27
==========================================
+ Hits 717 751 +34
- Misses 141 191 +50
- Partials 23 28 +5
☔ View full report in Codecov by Sentry. |
tpike3
reviewed
Nov 1, 2023
Member
tpike3
left a comment
tpike3
left a comment
There was a problem hiding this comment.
Thanks @ankitk50. I just had a few requested changes and was curious about one aspect of rendering the browser. Then we can get this merged and out the door.
@rht and @jackiekazil
tpike3
reviewed
Nov 2, 2023
Member
|
Could you take a look at the build failures as well please |
Contributor
Author
|
seems like I need to add some tests to improve the code coverage. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Features of the user interface