Skip to content

Add Governance Document#1836

Closed
tpike3 wants to merge 1 commit intomesa:mainfrom
tpike3:governance
Closed

Add Governance Document#1836
tpike3 wants to merge 1 commit intomesa:mainfrom
tpike3:governance

Conversation

@tpike3
Copy link
Copy Markdown
Member

@tpike3 tpike3 commented Oct 16, 2023

  • Add governance document
  • Convert contributing guideline from .rst to .md
  • Update links in README

- Convert contributing guideline from .rst to .md
- Update links in README

Contributors engage with the project through the issue tracker, discussion board, discussion forum or by writing or
editing documentation. They submit changes to the project itself via pull requests and [following the contributing
guidelines](https://github.com/projectmesa/mesa/blob/main/CONTRIBUTING.rst), which will be considered for inclusion in
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be CONTRIBUTING.md

* A response within 7 days. If you do not see a response, please send us a note on our [matrix channel](https://matrix.to/#/#project-mesa:matrix.org)
* A clear list or description of what is necessary for the code to be merged (as much possible)
* If a pull request is not merged after two rounds of substantive feedback from one committer and new committer will
volunteer to review and help the pull request be merged. THis is for substantive feedback and not administrative
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo "THis".

@@ -0,0 +1,125 @@
# Mesa Governance
(adopted from OSS Watch - http://oss-watch.ac.uk/resources/meritocraticgovernancemodel )
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wang-boyu
Copy link
Copy Markdown
Member

Thanks @tpike3 for putting these together! A couple of thoughts and questions:

Linking back to why these documents are here, I'm more interested in how PRs are going to be reviewed and merged moving forward. In the new GOVERNANCE.md under Committers section, it says

Committers are expected to:

  • Provide positive feedback to contributors (they are volunteers), this can include but is not limited to thank you, compliments.
  • Provide a clear and concise description of those elements that will allow the pull request to me merged
  • Mentorship as needed
  • Finding a new committer to review the pull request if two rounds of substantive feedback, still needs substantive feedback.

If I understand this correctly, this means we'll change our current review process, so that another reviewer will work on the PR if it stills needs substantive feedback after two rounds of substantive feedbacks?

In regards to how committers/maintainers are expected to treat and review PRs, there are more words, for example from Healthy Open Source, which mentioned things like

Rather than the default mode for a change to be rejected until enough people sign off, we make the default for every change to land. This puts the onus on reviewers to note exactly what adjustments need to be made in order for it to land.

For NumPy there's also a reviewer guideline that looks pretty comprehensive.

I'm not agreeing or disagreeing, or suggesting that we should simply follow these guidelines. Just wondering what would be a best way for us to review future PRs : )

On a side note, I also want to use this opportunity to thank @rht for responding to almost everything in this project!

@EwoutH EwoutH mentioned this pull request Nov 1, 2023
@tpike3 tpike3 closed this by deleting the head repository Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants