Skip to content

Move examples from mesa repo to mesa-examples repo. #1529

Merged
rht merged 5 commits intomainfrom
jk/mv-examples
Dec 5, 2022
Merged

Move examples from mesa repo to mesa-examples repo. #1529
rht merged 5 commits intomainfrom
jk/mv-examples

Conversation

@jackiekazil
Copy link
Copy Markdown
Member

No description provided.

@codecov
Copy link
Copy Markdown

codecov bot commented Dec 5, 2022

Codecov Report

Base: 91.28% // Head: 81.44% // Decreases project coverage by -9.83% ⚠️

Coverage data is based on head (248037f) compared to base (c9f10a6).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1529      +/-   ##
==========================================
- Coverage   91.28%   81.44%   -9.84%     
==========================================
  Files          15       16       +1     
  Lines        1308     1326      +18     
  Branches      229      230       +1     
==========================================
- Hits         1194     1080     -114     
- Misses         80      203     +123     
- Partials       34       43       +9     
Impacted Files Coverage Δ
...esa/visualization/modules/BarChartVisualization.py 16.66% <0.00%> (-72.23%) ⬇️
mesa/visualization/modules/ChartVisualization.py 25.00% <0.00%> (-66.67%) ⬇️
...esa/visualization/modules/PieChartVisualization.py 25.00% <0.00%> (-66.67%) ⬇️
mesa/visualization/modules/HexGridVisualization.py 33.33% <0.00%> (-62.97%) ⬇️
mesa/visualization/modules/NetworkVisualization.py 41.66% <0.00%> (-58.34%) ⬇️
mesa/main.py 78.57% <0.00%> (-17.86%) ⬇️
mesa/visualization/ModularVisualization.py 68.32% <0.00%> (-10.56%) ⬇️
mesa/space.py 91.57% <0.00%> (-4.22%) ⬇️
mesa/time.py 91.00% <0.00%> (-4.00%) ⬇️
mesa/datacollection.py 95.34% <0.00%> (-2.33%) ⬇️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jackiekazil jackiekazil marked this pull request as ready for review December 5, 2022 03:59
@jackiekazil jackiekazil requested a review from rht December 5, 2022 03:59
@jackiekazil
Copy link
Copy Markdown
Member Author

Note: Tests -- there are some tests that I labeled as "skip". I think we need to have a further conversation about the tests and the examples repo, but I personally don't want that to hold the first iteration of the move to be held up by this.

@jackiekazil jackiekazil changed the title Move examples from mesa repo to mesa-examples repo. [WIP] Move examples from mesa repo to mesa-examples repo. Dec 5, 2022
return "".join(x.capitalize() for x in name.replace("-", "_").split("_"))


@unittest.skip(
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test is dependent on examples folder being here, so we are skipping until we discuss testing strategy.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could move the tests to mesa-examples.

def tearDown(self):
sys.path[:] = self.old_sys_path

@unittest.skip(
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test is dependent on examples folder being here, so we are skipping until we discuss testing strategy.

@rht
Copy link
Copy Markdown
Contributor

rht commented Dec 5, 2022

mesa/mesa-examples#10 has been merged, so I'm merging now.

@rht rht merged commit 9bc7b1a into main Dec 5, 2022
@rht
Copy link
Copy Markdown
Contributor

rht commented Dec 5, 2022

I deleted the temp working branch as well.

@rht rht deleted the jk/mv-examples branch December 5, 2022 07:35
@tpike3 tpike3 added this to the Mesa 2.0 milestone Dec 8, 2022
@tpike3 tpike3 removed this from the Mesa 2.0 (Wellton) milestone Jul 2, 2023
@EwoutH
Copy link
Copy Markdown
Member

EwoutH commented Sep 3, 2024

It’s a shame all git history was lost in this move. That wasn’t necessary at all. There are way more elegant ways to approach this using git. git filter-repo for example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants