Codecov Report

Merging #1247 (5c10504) into main (c6f0dc2) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1247   +/-   ##
=======================================
  Coverage   89.08%   89.08%           
=======================================
  Files          19       19           
  Lines        1310     1310           
  Branches      265      265           
=======================================
  Hits         1167     1167           
  Misses        104      104           
  Partials       39       39           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6f0dc2...5c10504. Read the comment docs.

The PR content looks good to me, but the commit message needs to be changed to be in imperative mood.
https://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html

Write your commit message in the imperative: "Fix bug" and not "Fixed bug"
or "Fixes bug." This convention matches up with commit messages generated
by commands like git merge and git revert.

To save time: you can edit the commit message with git commit --amend, and then git push -f when pushing to your remote, because editing a commit message means you are rewriting history, and so, it needs a force push.

There is a tool that can be used to check the commit message: https://jorisroovers.com/gitlint/.

Thanks @rht! However, gitlint didn't complain about the original commit message. Some specific configuration required?

It should be PDAgent.step instead of PDAgent.step.

Hmm, yeah, forgot to say that the gitlint invocation needs some extra config.
E.g. gitlint --contrib contrib-title-conventional-commits but we don't follow Conventional Commits on Mesa -- this is just an example

I will add a gitlint CI hook later.

Merged, thank you!