[Issue 1232] Refactor NetworkModuleSigma PieChartModule TextModule JS#1246
Conversation
|
Hi @trickroll and thanks for the contribution! I am not sure which rule you applied for deciding between let and const. Normally you should use const whenever possibly and only use let if it is not possible otherwise. |
|
@Corvince Thank you for feedback! Let me revisit the const vs let. Apologies about the thrash and appreciate the patience. Understand that there are benefits to making variables immutable |
|
Everything else looks good to me.
|
|
If you want to programmatically catch these reassignment errors, you can use eslint. It should tell you this error if you specify Pinging @SangameshItagi because this info is useful for him as well. |
…ule_signma.js with const/let
|
@rht - Thank you for your guidance and support! Makes a huge difference for a beginner :) |
|
LGTM |
|
Merged, thank you! |
Addresses some, but not all, of the files referenced in issue #1232
Refactored "var" into const/let for:
Please tell me if there is anything I may need to fix or change! Thank you and welcome the feedback.