-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
JupyterViz space view limits #1977
Description
What's the problem this feature will solve?
At the moment, when drawing spaces with JupyterViz, the axes limits are left to be automatically determined by Matplotlib. Would it not make more sense (in particular of continuous spaces, to derive xlim and xmax from the space itself?
Describe the solution you'd like
The simplest fix would be to adapt _draw_grid to use space.width and space.height while _draw_continuos_space uses space.x_min, space.x_max, space.y_min, and space.y_max. Are there reasons where the user might want to rely on matpltolib's automatic determination of the bounds? If so, then a slightly more sophisticated solution would be needed where kwargs are passed to from jupyterviz to the underlying space_drawer function. So you would add a space_drawer_kwargs keyword argument.