Repository navigation
fix(parser): reject await in the concise body of a non-async arrow in module code - #673
Merged
Merged
Conversation
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In module code, meriyah accepted
awaitused as an expression in the concise body of a non-async arrow function:An arrow's concise body is
ConciseBody[~Await]for non-async arrows, soawaitthere is neither anAwaitExpressionnor (in module code) a valid identifier — these are early errors. acorn rejects all three. The block-body form (x => { await x }) was already rejected, because the function body parser clearsContext.InGlobal; the concise-body path kept it, so top-level-await handling leaked into the arrow.The fix adds
Context.InGlobalto the flags cleared inparseArrowFunctionExpression, so both body forms behave the same.Tests: three new
failcases intest/parser/expressions/arrow.ts(they pass parsing without the fix). The full suite (92,032 tests, rebased on main) andnpm run lintpass.