Repository navigation
Add Vitest suite for expense split logic - #413
Merged
Merged
Conversation
Contributor
|
MergeKeeper review Scope: in scope for linked issue The PR successfully adds a comprehensive Vitest unit test suite covering split calculation logic in accordance with issue requirements. Reviewed commit: |
Godsdar
force-pushed
the
feat/split-vitest-suite
branch
from
August 29, 2026 13:42
1995b05 to
e08e42a
Compare
Godsdar
force-pushed
the
feat/split-vitest-suite
branch
from
August 29, 2026 13:43
e08e42a to
688d522
Compare
![mergekeeper[bot]](https://avatars.githubusercontent.com/u/173216192?s=60&v=4){kind=small}
Contributor
|
Merged Merged with |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a Vitest suite for the split helpers in src/lib/split.ts — splitEqual, splitByPercentage, splitByCustom, plus the edge cases of computeSharesAmounts: even splits with remainders, the exact-sum invariant, custom amounts, zero-balance participants, and a 1B XLM precision check.
Put it in src/lib/split.vitest.test.ts rather than tests/split.test.ts, because that path already holds the node:test suite (run via tsx), and the repo's Vitest tests live as *.vitest.test.ts next to the source. 18 tests, all pass via vitest run; typecheck and eslint are clean.
Closes #306