Add an option for disabling the workqueue bucket rate limiter#6
Merged
tfujiwar merged 1 commit intomercari-masterfrom Nov 29, 2024
Merged
Conversation
djahandarie
reviewed
Nov 29, 2024
| if autoScalingRunnerSetOnly { | ||
| var newWorkqueueRateLimiter func() workqueue.RateLimiter | ||
| if disableWorkqueueBucketRateLimiter { | ||
| newWorkqueueRateLimiter = workqueue.DefaultItemBasedRateLimiter |
There was a problem hiding this comment.
Not sure what version of workqueue this code is on, but in latest versions DefaultItemBasedRateLimiter is considered deprecated: "Deprecated: DefaultItemBasedRateLimiter is deprecated, use DefaultTypedItemBasedRateLimiter instead."
djahandarie
reviewed
Nov 29, 2024
| if disableWorkqueueBucketRateLimiter { | ||
| newWorkqueueRateLimiter = workqueue.DefaultItemBasedRateLimiter | ||
| } else { | ||
| newWorkqueueRateLimiter = workqueue.DefaultControllerRateLimiter |
djahandarie
approved these changes
Nov 29, 2024
djahandarie
left a comment
djahandarie
left a comment
There was a problem hiding this comment.
LGTM since it's just to test hypothesis, can clean it up later as needed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We observed that many EpehemralRunners were waiting for reconciliation after a JITConfig secret was created. This is likely because the next reconciliation is not enqueued by returning
Result{Requeue: true}and such requeued reconciliations are rate limited by the workqueue rate limiter.https://github.com/actions/actions-runner-controller/blob/8b36ea90ebe81710fcdcb4f96424b43203d24f1e/controllers/actions.github.com/ephemeralrunner_controller.go#L681-L682
The default rate limiter is defined by a combination of
NewTypedItemExponentialFailureRateLimiterandTypedBucketRateLimiter.https://github.com/kubernetes/client-go/blob/37045084c2aa82927b0e5ffc752861430fd7e4ab/util/workqueue/default_rate_limiters.go#L50-L56
This PR adds an option for disabling the
TypedBucketRateLimiter.