fix(extension): preserve shared popup close-state behavior in builds#1257
Merged
mengxi-ream merged 1 commit intomainfrom Mar 30, 2026
Merged
fix(extension): preserve shared popup close-state behavior in builds#1257mengxi-ream merged 1 commit intomainfrom
mengxi-ream merged 1 commit intomainfrom
Conversation
🦋 Changeset detectedLatest commit: 22a7f31 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
This PR moves the popup closed-state contract into a shared Base UI helper so popup primitives preserve the correct closed-state behavior in production builds.
data-closed:pointer-events-noneanddata-closed:[animation-fill-mode:forwards]Related Issue
Closes #
How Has This Been Tested?
Commands run:
SKIP_FREE_API=true pnpm exec vitest run src/components/ui/base-ui/__tests__/popup-animation-classes.test.ts src/entrypoints/selection.content/components/__tests__/action-tooltips.test.tsx src/entrypoints/selection.content/components/__tests__/selection-toolbar-footer-content.test.tsxpnpm exec eslint src/components/ui/base-ui/alert-dialog.tsx src/components/ui/base-ui/combobox.tsx src/components/ui/base-ui/dialog.tsx src/components/ui/base-ui/dropdown-menu.tsx src/components/ui/base-ui/hover-card.tsx src/components/ui/base-ui/popover.tsx src/components/ui/base-ui/select.tsx src/components/ui/base-ui/sheet.tsx src/components/ui/base-ui/tooltip.tsx src/components/ui/base-ui/popup-animation-classes.ts src/components/ui/base-ui/__tests__/popup-animation-classes.test.ts src/entrypoints/selection.content/components/selection-toolbar-footer-content.tsx src/entrypoints/selection.content/components/selection-tooltip.tsxpnpm type-checkpnpm buildScreenshots
Not applicable.
Checklist
Additional Information
tmp/selection-repro.htmlwas kept local and is not part of the PR.Summary by cubic
Fixes popup close-state regressions in production builds by centralizing the closed-state styles and applying them to all Base UI popups. Closed popups are now non-interactive and their exit animations complete reliably.
Written for commit 22a7f31. Summary will update on new commits.