Skip to content

fix: firefox consent required field#1139

Merged
ananaBMaster merged 2 commits intomainfrom
fix/firefox-consent-required-field
Mar 17, 2026
Merged

fix: firefox consent required field#1139
ananaBMaster merged 2 commits intomainfrom
fix/firefox-consent-required-field

Conversation

@ananaBMaster
Copy link
Copy Markdown
Collaborator

@ananaBMaster ananaBMaster commented Mar 17, 2026

Type of Changes

  • ✨ New feature (feat)
  • 🐛 Bug fix (fix)
  • 📝 Documentation change (docs)
  • 💄 UI/style change (style)
  • ♻️ Code refactoring (refactor)
  • ⚡ Performance improvement (perf)
  • ✅ Test related (test)
  • 🔧 Build or dependencies update (build)
  • 🔄 CI/CD related (ci)
  • 🌐 Internationalization (i18n)
  • 🧠 AI model related (ai)
  • 🔄 Revert a previous commit (revert)
  • 📦 Other changes that do not modify src or test files (chore)

Description

Related Issue

Closes #

How Has This Been Tested?

  • Added unit tests
  • Verified through manual testing

Screenshots

Checklist

  • I have tested these changes locally
  • I have updated the documentation accordingly if necessary
  • My code follows the code style of this project
  • My changes do not break existing functionality
  • If my code was generated by AI, I have proofread and improved it as necessary.

Additional Information


Summary by cubic

Fixes Firefox validation by adding the missing required consent field to the extension manifest, aligning with the data_collection_permissions schema and unblocking AMO publishing for @read-frog/extension. Sets required: [] in wxt.config.ts to indicate no required data collection.

Written for commit 7e69f65. Summary will update on new commits.

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 17, 2026

🦋 Changeset detected

Latest commit: 7e69f65

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@read-frog/extension Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Mar 17, 2026
@github-actions github-actions bot added the fix label Mar 17, 2026
@ananaBMaster ananaBMaster merged commit 341adba into main Mar 17, 2026
5 checks passed
@ananaBMaster ananaBMaster deleted the fix/firefox-consent-required-field branch March 17, 2026 04:40
@dosubot dosubot bot added the app: browser extension Related to browser extension label Mar 17, 2026
@dosubot
Copy link
Copy Markdown

dosubot bot commented Mar 17, 2026

Documentation Updates

1 document(s) were updated by changes in this PR:

Build and Development Environment Setup
View Changes
@@ -216,6 +216,7 @@
     id: "{bd311a81-4530-4fcc-9178-74006155461b}",
     strict_min_version: "112.0",
     data_collection_permissions: {
+      required: [],
       optional: ["technicalAndInteraction"],
     },
   },

How did I do? Any feedback?  Join Discord

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app: browser extension Related to browser extension fix size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant