fix(translation): skip github PR review diff tables (#1175)

frogGuaGuaGuaGua · web-flow · commit cca465ad040a · 2026-03-20T21:08:13.000-07:00
Co-authored-by: GuaGua &lt;268840081+frogGuaGuaGuaGua@users.noreply.github.com&gt;
diff --git a/.changeset/github-pr-comment-diff-table.md b/.changeset/github-pr-comment-diff-table.md
@@ -0,0 +1,5 @@
+---
+"@read-frog/extension": patch
+---
+
+fix(translation): skip GitHub PR review diff tables during page translation
diff --git a/src/utils/constants/dom-rules.ts b/src/utils/constants/dom-rules.ts
@@ -151,6 +151,7 @@ export const CUSTOM_DONT_WALK_INTO_ELEMENT_SELECTOR_MAP: Record<string, string[]
     "header *",
     "#repository-container-header *",
     "[class*=\"OverviewContent-module__Box_1--\"] *",
+    "table.diff-table", // https://github.com/mengxi-ream/read-frog/issues/1174
   ],
 }
 
diff --git a/src/utils/host/__tests__/translate.integration.test.tsx b/src/utils/host/__tests__/translate.integration.test.tsx
@@ -43,6 +43,14 @@ const TRANSLATION_ONLY_CONFIG: Config = {
   },
 }
 
+function setHost(host: string) {
+  Object.defineProperty(window, "location", {
+    value: new URL(`https://${host}/some/path`),
+    writable: true,
+    configurable: true,
+  })
+}
+
 describe("translate", () => {
   // Setup and teardown for getComputedStyle mock
   const originalGetComputedStyle = window.getComputedStyle
@@ -1320,6 +1328,41 @@ describe("translate", () => {
       })
     })
 
+    describe("github diff table - should not translate review code snippets", () => {
+      it("bilingual mode: should skip github diff-table content entirely", async () => {
+        const originalLocation = window.location
+        setHost("github.com")
+        vi.mocked(translateTextForPage).mockClear()
+
+        try {
+          render(
+            <div data-testid="test-node">
+              <table className="diff-table">
+                <tbody>
+                  <tr>
+                    <td>const foo = 1</td>
+                  </tr>
+                </tbody>
+              </table>
+            </div>,
+          )
+          const node = screen.getByTestId("test-node")
+          await removeOrShowPageTranslation("bilingual", true)
+
+          expect(node.querySelector(`.${CONTENT_WRAPPER_CLASS}`)).toBeFalsy()
+          expect(node.textContent).toBe("const foo = 1")
+          expect(translateTextForPage).not.toHaveBeenCalled()
+        }
+        finally {
+          Object.defineProperty(window, "location", {
+            value: originalLocation,
+            writable: true,
+            configurable: true,
+          })
+        }
+      })
+    })
+
     describe("code tag - should not walk into but translate as child", () => {
       it("bilingual mode: should translate text with code elements", async () => {
         render(
diff --git a/src/utils/host/dom/__tests__/custom-dont-walk.test.ts b/src/utils/host/dom/__tests__/custom-dont-walk.test.ts
@@ -1,7 +1,7 @@
 // @vitest-environment jsdom
 import { afterEach, describe, expect, it } from "vitest"
 import { DEFAULT_CONFIG } from "@/utils/constants/config"
-import { isCustomDontWalkIntoElement, isDontWalkIntoAndDontTranslateAsChildElement } from "../filter"
+import { hasNoWalkAncestor, isCustomDontWalkIntoElement, isDontWalkIntoAndDontTranslateAsChildElement } from "../filter"
 
 function setHost(host: string) {
   // jsdom exposes location as read-only; override via defineProperty
@@ -104,4 +104,25 @@ describe("isCustomDontWalkIntoElement", () => {
     expect(isCustomDontWalkIntoElement(postFlair)).toBe(true)
     expect(isDontWalkIntoAndDontTranslateAsChildElement(postFlair, DEFAULT_CONFIG)).toBe(true)
   })
+
+  it("matches github review diff table and blocks its descendants", () => {
+    setHost("github.com")
+
+    const diffTable = document.createElement("table")
+    diffTable.classList.add("diff-table")
+
+    const tbody = document.createElement("tbody")
+    const tr = document.createElement("tr")
+    const td = document.createElement("td")
+    td.textContent = "const foo = 1"
+
+    tr.appendChild(td)
+    tbody.appendChild(tr)
+    diffTable.appendChild(tbody)
+    document.body.appendChild(diffTable)
+
+    expect(isCustomDontWalkIntoElement(diffTable)).toBe(true)
+    expect(isDontWalkIntoAndDontTranslateAsChildElement(diffTable, DEFAULT_CONFIG)).toBe(true)
+    expect(hasNoWalkAncestor(td, DEFAULT_CONFIG)).toBe(true)
+  })
 })

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +---
 +"@read-frog/extension": patch
 +---
++
 +fix(translation): skip GitHub PR review diff tables during page translation
Original file line number	Diff line number	Diff line change
`@@ -151,6 +151,7 @@ export const CUSTOM_DONT_WALK_INTO_ELEMENT_SELECTOR_MAP: Record<string, string[]`
`151`	`151`	`"header *",`
`152`	`152`	`"#repository-container-header *",`
`153`	`153`	`"[class=\"OverviewContent-module__Box_1--\"] ",`
	`154`	`+ "table.diff-table", // https://github.com/mengxi-ream/read-frog/issues/1174`
`154`	`155`	`],`
`155`	`156`	`}`
`156`	`157`