fix(web): hide Settings Runtime group header in prod (closes #701)#736
Merged
pandas-studio merged 1 commit intomainfrom May 3, 2026
Merged
Conversation
pandas-studio
approved these changes
May 3, 2026
Collaborator
pandas-studio
left a comment
pandas-studio
left a comment
There was a problem hiding this comment.
Hide mechanism is doubly safe — _applyUiModeFilter (app.js:170) sets both hidden=true and inline display:none, plus the global [hidden] { display: none !important } rule at style.css:6 backstops it. Click-handler / collapse-state passes that still iterate the now-hidden runtime group in prod are harmless (wasted work, not a bug).
Trade-off vs. option 2 (compute group visibility from children) correctly justified — all four runtime children are dev-only by design today, so the smaller diff is the right scope. If a future contributor adds a prod-tier child to runtime, breakage is obvious in dev preview.
Approving.
The Runtime nav group at index.html:650 contained four dev-tier child buttons (harness-sessions/scratch/procedures/health) but the group header itself had no `data-ui-tier` marker, so `_applyUiModeFilter` (app.js:170) walked past it. In prod the header stayed clickable and expanded to nothing — caret flipped, no children appeared, content panel kept showing the previously-selected section. Mark the group header `data-ui-tier="dev"` so it shares the same hide pass as its children. All four runtime children are dev-only by design (packages/memtomem/src/memtomem/web/static/index.html:654-680), so the header is unconditionally dev-tier — no need for the more general "compute group visibility from children" approach (option 2 in #701). Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
memtomem
force-pushed
the
fix/701-settings-runtime-group-dev-tier
branch
from
cd909c6 to
8406067
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
data-ui-tiermarker, so_applyUiModeFilter(app.js:170) walked past it. In prod the header stayed clickable and expanded to nothing — caret flipped, no children appeared, content panel kept showing the previously-selected section.data-ui-tier="dev"so it shares the same hide pass as its four already-dev-tier children (harness-sessions,harness-scratch,harness-procedures,harness-health).Closes #701.
Test plan
?ui_mode=devor env toggle), confirm Runtime group still expands and shows all four children (Sessions / Working Memory / Procedures / Health Report)._applyUiModeFilterre-run).