style(web): mode toggle uses bottom-border (sub-tab convention) (#582)#589
Merged
style(web): mode toggle uses bottom-border (sub-tab convention) (#582)#589
Conversation
The Index tab's mode toggle (folder / upload / compose) used the global .btn-ghost.btn-active outline, while the main .tab-nav above already uses a bottom-border for its active tab. Both rendering as a blue highlight with different decoration (outline vs underline) weakens the parent/child hierarchy between main tabs and sub-tabs. Switch the mode toggle's active state to the same bottom-border convention used by .sources-vendor-tab so both rows read as tabs but at different scales — main tabs stay larger and prominent, the mode toggle reads as subordinate. Refs #582 (Prev #4). Co-Authored-By: Claude <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.btn-ghost.btn-activeoutline (border on all four sides), while the main.tab-navabove already uses bottom-border for its active tab. Both rendered as a blue highlight with different decoration, which weakened the parent/child hierarchy between main tabs and sub-tabs..sources-vendor-tab. Both rows now read as tabs at different scales — main tabs stay larger/prominent, the mode toggle reads as subordinate..sources-mode-toggleselector to point at the live.sources-vendor-tabprecedent.Scope
packages/memtomem/src/memtomem/web/static/style.css..index-mode-toggle .btn-ghost { font-size: 0.82rem; padding: 4px 12px; }rule with a fuller block (background/border reset + inactive/hover/active states), plus an updated header comment. +15 / -3 lines.btn.classList.toggle('btn-active', active)inapp.js:2983) keeps working unchanged — only the CSS interpretation ofbtn-activeinside.index-mode-toggleis rewritten..index-mode-toggle .btn-ghost.btn-active(0,0,3,0) overrides the global.btn-ghost.btn-active(0,0,2,0). Other consumers ofbtn-active(filter-toggle,adv-toggle,group-toggle,tags-cloud-btn,tags-list-btn,tags-sort-btn) are unaffected.Refs
569dca7).Test plan
uv run ruff check packages/memtomem/src && uv run ruff format --check packages/memtomem/src파일 업로드(Upload) active and폴더 인덱싱(Folder) active. Active mode reads as a clean bottom-border tab; inactive modes show muted text with no border. Main.tab-navrow keeps its existing bottom-border style — hierarchy is now layered (large main tabs → smaller mode toggle, both bottom-border). Confirmed PR style(web): cap upload dropzone width and center it (#582) #588's centered dropzone still renders correctly under the new mode-toggle row..btn-activeconsumers (filter-toggle,adv-toggle,group-toggle,tags-*) inherit any of the new scoped declarations.🤖 Generated with Claude Code