docs(adr): graduate ADR-0002 — per-entry blockquote tags#472
Merged
Conversation
Promote the `mem-add-tags-blockquote-promote-rfc` design doc from the private memtomem-docs planning area to the public ADR set, now that the reader (#463), writer (#464), batch-broadcast cleanup (#465), and line-counter follow-ups (#466, #468) have all shipped in v0.1.28. Updates source-of-truth file:line references to v0.1.28 layout, drops the deferred telemetry section (counters were not wired), and folds the `mem_edit` header-preservation note into the Decision section since `replace_chunk_body` landed alongside the writer change. Adds an inbound link from `docs/guides/reference.md` mem_add section so users searching for "tag_filter" or "tags" hit the on-disk format contract. Co-Authored-By: Claude <[email protected]>
Reverse-discoverability follow-up to the ADR graduation. The lead paragraph already mentions blockquote tag promotion as the largest behavior change of the release; add a one-line pointer to the new ADR so readers landing on the changelog entry can jump to the full rationale instead of inferring it. Co-Authored-By: Claude <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mem-add-tags-blockquote-promote-rfc.mdfrom the privatememtomem-docs/planning/area to a public ADR (docs/adr/0002-…)now that the implementation has fully shipped in v0.1.28.
layout (writer at
memory_writer.py:33, reader helpers atchunking/markdown.py:259–384, etc.) and folds in themem_editheader-preservation behaviour from PR feat(mem_add,mem_edit): canonical writer + mem_edit header preservation #464 and the
add_entries_batchbroadcast cleanup from PR fix(mem_batch_add): drop post-index tag broadcast; per-entry tags isolated #465 — both of whichwere drafted as follow-ups in the original RFC and landed during
the same v0.1.28 train.
frontmatter_tags_seen/blockquote_tags_seenwebhook counterswere not wired, and the existing
chunks_indexedcounter issufficient for the now-stable behaviour.
docs/guides/reference.md(themem_addparameter table) and a reverse cross-link from the v0.1.28
CHANGELOG.mdlead paragraph for discoverability in bothdirections.
Promotion gate (
PROMOTION-CRITERIA.md)not met. v0.1.28 is a patch bump, not a minor; PRs
feat(chunking): promote per-entry blockquote tags to ChunkMetadata.tags #463/feat(mem_add,mem_edit): canonical writer + mem_edit header preservation #464/fix(mem_batch_add): drop post-index tag broadcast; per-entry tags isolated #465/fix(chunking): seed _split_section line counter past stripped blockquote header #466/fix(chunking): drop +1 paragraph-gap overshoot in _split_section end_line #468 all landed in the same release train,
so this is 1 release cycle, not 2. Promoting now anyway because
(a) the on-disk format is documented in the v0.1.28 CHANGELOG
entry, (b) the only known recovery gap (UUID churn breaking
shared-from=<old-uuid>audit chains) is structurally closedby the chunk_links follow-up feat(storage): add chunk_links table + one-shot back-fill from shared-from tags #469/feat(multi-agent): chunk_links writer + reader API; mem_agent_share records link #470 in the same release,
and (c) external users have already started pinning to v0.1.28.
Future ADR promotions should hit the literal criterion or
annotate the same way.
30e87a1(release commit)Status: Draft→Accepted,"Tracked by"/"follow-up to" phrasing rewritten as past tense
docs/guides/reference.mdmem_add section +CHANGELOG.mdv0.1.28 leadThe private
memtomem-docscopy of the RFC was never committed(stayed as an untracked working-tree file). Once this PR merges I'll
remove it locally — no companion private PR needed.
Test plan
docs/adr/0002-mem-add-blockquote-tags.mdongithub.com;
../adr/0002-…relative link fromdocs/guides/reference.mdresolves correctly.ruff check,ruff format --check, pytestnot ollama) — docs-only diff, expected unaffected.🤖 Generated with Claude Code