typing(config): remove 4 type:ignore in coerce_and_validate#188
Merged
typing(config): remove 4 type:ignore in coerce_and_validate#188
Conversation
- Widen coerced annotation from object to the actual union - Add isinstance guards before int()/float() calls to narrow value - Use cast for unreachable else fallback - Narrow min/max constraint values with isinstance for < / > operators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
`bool | int | float | str | list[object]` — the actual union the
variable inhabits at runtime.
calls so mypy can verify the overload resolution.
`FIELD_CONSTRAINTS` type reaches it).
`>` operators type-safe.
Closes #101