Skip to content

web: i18n coverage for remaining hardcoded showConfirm/showToast strings #29

@tsdata

Description

@tsdata

Summary

After the initial i18n pass (commit 0c65e74), there are still ~28 hardcoded English strings in app.js that should be routed through t() for Korean translation support.

Scope

showConfirm — 7 call sites with hardcoded English

Line Context Strings needed
1290 Delete chunk title, message, confirmText
1477 Bulk delete title, message, confirmText
1750 Delete source title, message, confirmText
1890 Delete chunk from source view title, message, confirmText
2327 Merge duplicate (keep A) title, message, confirmText
2331 Merge duplicate (keep B) title, message, confirmText
2407 Expire chunks title, message, confirmText

showToast — 21 call sites with hardcoded English

Template literal toasts (lines 2062, 2102, 2205, 2424, 2640, 2713, 2805, 3572, 3575, 3664, 3667, 4732, 4756, 4792, 4880, 4998, 5007, 5185, 5242, 6202) and one plain string toast (line 6208).

Estimated effort

  • ~28 new keys in both locales/en.json and locales/ko.json
  • Many use {count}, {name}, {error} interpolation patterns already supported by t()
  • No structural changes needed — just string replacement

Notes

  • Line numbers reference the current main branch after commit 0c65e74
  • Both en.json and ko.json must stay in sync (368 keys currently)
  • The showConfirm() function's default confirmText = 'Confirm' (line 243) should also be converted to t('common.confirm') or similar

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions