fix: encode dynamic URL path segments in SDK and CLI requests#5905
Open
Rsmiyani wants to merge 1 commit into
Open
fix: encode dynamic URL path segments in SDK and CLI requests#5905Rsmiyani wants to merge 1 commit into
Rsmiyani wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked Issue
Closes #5893
Closes #5818
Description
This PR fixes an issue where hosted SDK and CLI methods build API URLs by interpolating caller-provided identifiers directly into URL path segments. When these identifiers contain URL-structural characters (such as
/,?, or#), they alter the generated request URL semantics instead of being treated as a literal path segment.We resolve this by percent-encoding the dynamic path segment values before inserting them into API paths (e.g. converting
org/team?active#frag->org%2Fteam%3Factive%23frag).Affected areas fixed:
memory_idand entity names inmain.pyusingurllib.parse.quote(..., safe='').platform.pyusingurllib.parse.quote(..., safe='').mem0.tswithencodeURIComponent().platform.tswithencodeURIComponent().Type of Change
Breaking Changes
N/A
Test Coverage
Added comprehensive unit tests to verify that structural characters in path parameters are properly percent-encoded:
TestUrlEncodingandTestAsyncUrlEncodingintests/test_client.py.cli/python/tests/test_backend.py.mem0-ts/src/client/tests/memoryClient.urlEncoding.test.ts.cli/node/tests/backend.test.ts.Checklist