Repository navigation
fix(ts): request float OpenAI embeddings - #5170
Merged
blazingretinol merged 4 commits intoJun 4, 2026
Merged
blazingretinol merged 4 commits into
blazingretinol merged 4 commits into
Conversation
|
|
…bedder-float-encoding
|
Confirmed against the reproduction in #5168 — this fix ( We've been running an equivalent runtime-wrapper patch in production since 2026-05-01 without regressions. Diff is minimal and mirrors the Python #4058 fix. LGTM 👍 |
This was referenced May 28, 2026
blazingretinol
approved these changes
Jun 4, 2026
whysosaket
approved these changes
Jun 4, 2026
blazingretinol
approved these changes
Jun 4, 2026
blazingretinol
added a commit
that referenced
this pull request
Jun 10, 2026
Python v2.0.5 additions: - feat: add explain=True search score breakdowns (#5102) - fix(memory): reject empty/whitespace search queries (#5258) - fix(llms/xai): forward tools, add XAIConfig, parse tool_calls (#5190) - fix(pgvector): use open=False to prevent ConnectionPool hang in Docker (#5155) - fix(vector-stores): filter S3 vector list results client-side (#5018) - fix(vector_stores): Upstash namespace passed as top-level kwarg (#5202) TypeScript v3.0.7 additions: - feat: add explain search score breakdowns (#5102) - fix(embeddings): request float encoding_format from OpenAI (#5170)
7 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
encoding_format: "float"from the TypeScript OSS OpenAI embedderembed()andembedBatch()embeddingDimsbehaviorWhy
The OpenAI Node SDK may request base64 embeddings by default when
encoding_formatis omitted. OpenAI-compatible proxies can mishandle that mode, returning vectors that decode to the wrong dimension and later fail in vector stores. This mirrors the Python SDK fix from #4058 for the TypeScript SDK path.Closes #5168.
Validation
pnpm exec jest src/oss/tests/openai-embedder.test.ts --runInBandpnpm run build