fix(openclaw): remove process.env access to clear security scanner warning#4676
Merged
whysosaket merged 1 commit intomainfrom Apr 2, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
…rning
OpenClaw's static analyzer flags process.env + network calls as
"credential harvesting". Removed resolveEnvVars() and resolveEnvVarsDeep()
from config.ts. OpenClaw already resolves ${VAR} in openclaw.json before
passing pluginConfig to register(), so plugin-side resolution was redundant.
Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
chaithanyak42
force-pushed
the
fix/remove-process-env-security-warning
branch
from
eb8355c to
adad1af
Compare
kartik-mem0
approved these changes
Apr 2, 2026
whysosaket
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes
process.envaccess from the plugin to clear OpenClaw's security scanner warning:Why
OpenClaw's static analyzer flags
process.env+ network calls as credential exfiltration. OurresolveEnvVars()read env vars to expand${MEM0_API_KEY}syntax, then the mem0ai SDK made HTTP calls — triggering the scanner.This was redundant: OpenClaw already resolves
${VAR}inopenclaw.jsonbefore passingpluginConfigto the plugin'sregister()function. The API key arrives pre-resolved.Fix
Removed
resolveEnvVars()andresolveEnvVarsDeep()fromconfig.ts. Zeroprocess.envaccess in the plugin bundle. Config values pass through as-is since OpenClaw handles env var substitution at the framework level.Files changed
openclaw/config.ts— removed 2 functions (25 lines), updated 2 call sites to pass values directly.