fix: make AsyncMemory.from_config a regular classmethod#4183
Merged
kartik-mem0 merged 1 commit intomem0ai:mainfrom Mar 30, 2026
Merged
fix: make AsyncMemory.from_config a regular classmethod#4183kartik-mem0 merged 1 commit intomem0ai:mainfrom
kartik-mem0 merged 1 commit intomem0ai:mainfrom
Conversation
from_config() contains no async operations (only MemoryConfig validation and cls() construction). Remove the async keyword so it can be called outside an async context, e.g. during FastAPI module initialization.
Contributor
Author
|
Hi — just a gentle bump on this. Happy to make any changes if needed! |
kartik-mem0
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
AsyncMemory.from_config()is declared asasyncbut contains no async operations — it only validates config and callscls(config). This forces users to useawaiteven in synchronous initialization contexts (e.g. FastAPI module-level setup).Remove the
asynckeyword so it can be called as a regular classmethod.Fixes #2755
Type of change
How Has This Been Tested?
Checklist: