chore: Add dependabot updates for pre-commit#9861
Merged
edgarrmondragon merged 4 commits intomainfrom Mar 9, 2026
Merged
Conversation
✅ Deploy Preview for meltano canceled.
|
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideConfigures Dependabot to manage pre-commit hook updates and fixes the pre-commit eslint mirror configuration by explicitly setting its language to JavaScript. Flow diagram for weekly Dependabot pre-commit update processflowchart TD
A["Scheduled weekly interval"] --> B["Dependabot checks pre-commit ecosystem in /"]
B --> C{"Outdated pre-commit hooks?"}
C -->|"No"| D["Do nothing"]
C -->|"Yes"| E["Respect 7-day cooldown between PRs"]
E --> F{"Cooldown active?"}
F -->|"Yes"| D
F -->|"No"| G["Create or update PR to bump pre-commit hooks"]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
edgarrmondragon
added
the
dependencies
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey - I've found 2 issues, and left some high level feedback:
- In
.github/dependabot.yml, there appears to be a stray double quote inpackage-ecosystem: pre-commit"that will likely break the YAML and should be removed. - In
.pre-commit-config.yaml, verify thatlanguage: javascriptis a valid pre-commit language for the eslint mirror; typicallylanguage: nodeorsystemis used, so this may not behave as intended.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- In `.github/dependabot.yml`, there appears to be a stray double quote in `package-ecosystem: pre-commit"` that will likely break the YAML and should be removed.
- In `.pre-commit-config.yaml`, verify that `language: javascript` is a valid pre-commit language for the eslint mirror; typically `language: node` or `system` is used, so this may not behave as intended.
## Individual Comments
### Comment 1
<location> `.github/dependabot.yml:4` </location>
<code_context>
version: 2
enable-beta-ecosystems: true
updates:
+ - package-ecosystem: pre-commit"
+ directory: "/"
+ schedule:
</code_context>
<issue_to_address>
**issue (bug_risk):** Stray quote in `package-ecosystem` value likely breaks YAML / Dependabot parsing.
The trailing `"` after `pre-commit` makes this invalid YAML and will likely cause Dependabot to skip or fail this config. Either remove the quote (`package-ecosystem: pre-commit`) or quote the entire value (`package-ecosystem: "pre-commit"`).
</issue_to_address>
### Comment 2
<location> `.pre-commit-config.yaml:56` </location>
<code_context>
- repo: https://github.com/pre-commit/mirrors-eslint
rev: v8.55.0 # Keep this in sync with the eslint "additional_dependency" below!
+ language: javascript
hooks:
- id: eslint
</code_context>
<issue_to_address>
**issue (bug_risk):** `language: javascript` is not a valid pre-commit language and will cause hook failures.
`javascript` is not a supported `language` value in pre-commit. For the eslint mirror, use `language: node` (or omit `language` to rely on the default). Leaving it as `javascript` will cause the hook to fail during install or run.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
edgarrmondragon
force-pushed
the
pre-commit-dependabot
branch
2 times, most recently
from
6a31e6a to
2314455
Compare
Signed-off-by: Edgar Ramírez Mondragón <[email protected]>
edgarrmondragon
force-pushed
the
pre-commit-dependabot
branch
from
13b972a to
58b641f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related
dependabot.ymldependabot-2.0.jsonschema to match current Dependabot features SchemaStore/schemastore#5381dependabot-2.0.jsonschema to match current Dependabot features SchemaStore/schemastore#5381 (comment)pre-commitis not supported yet zizmorcore/zizmor#1639Summary by Sourcery
Configure automated updates and compatibility for pre-commit tooling.
Enhancements:
Build: