melib/backends: remove obsolete ReadOnlyOp

epilys · epilys · commit 6d998f54c8ff · 2024-12-10T14:52:06.000+02:00
`ReadOnlyOp` is a wrapper over `dyn BackendOp` objects to provide a
read-only interface over Backend operations, however any write
operations have been removed for a long long time now, so this is
completely obsolete.

This commit removes it.

Signed-off-by: Manos Pitsidianakis &lt;manos@pitsidianak.is&gt;
diff --git a/meli/src/accounts.rs b/meli/src/accounts.rs
@@ -1208,12 +1208,7 @@ impl Account {
         self.collection.contains_key(&h)
     }
     pub fn operation(&self, h: EnvelopeHash) -> Result<Box<dyn BackendOp>> {
-        let operation = self.backend.read().unwrap().operation(h)?;
-        Ok(if self.settings.account.read_only {
-            ReadOnlyOp::new(operation)
-        } else {
-            operation
-        })
+        self.backend.read().unwrap().operation(h)
     }
 
     pub fn special_use_mailbox(&self, special_use: SpecialUsageMailbox) -> Option<MailboxHash> {
diff --git a/melib/src/backends.rs b/melib/src/backends.rs
@@ -50,7 +50,7 @@ pub mod prelude {
         AccountHash, BackendEvent, BackendEventConsumer, BackendMailbox, BackendOp,
         EnvelopeHashBatch, FlagOp, IsSubscribedFn, LazyCountSet, MailBackend,
         MailBackendCapabilities, MailBackendExtensionStatus, Mailbox, MailboxHash,
-        MailboxPermissions, ReadOnlyOp, RefreshEvent, RefreshEventKind, TagHash,
+        MailboxPermissions, RefreshEvent, RefreshEventKind, TagHash,
     };
     pub use crate::{
         conf::AccountSettings,
@@ -575,28 +575,6 @@ pub trait BackendOp: ::std::fmt::Debug + ::std::marker::Send + ::std::marker::Sy
     fn as_bytes(&self) -> ResultFuture<Vec<u8>>;
 }
 
-/// Wrapper for [`BackendOp`] that are to be set read-only.
-///
-/// Warning: Backend implementations may still cause side-effects (for example
-/// IMAP can set the Seen flag when fetching an envelope)
-#[derive(Debug)]
-pub struct ReadOnlyOp {
-    op: Box<dyn BackendOp>,
-}
-
-impl ReadOnlyOp {
-    #[allow(clippy::new_ret_no_self)]
-    pub fn new(op: Box<dyn BackendOp>) -> Box<dyn BackendOp> {
-        Box::new(Self { op })
-    }
-}
-
-impl BackendOp for ReadOnlyOp {
-    fn as_bytes(&self) -> ResultFuture<Vec<u8>> {
-        self.op.as_bytes()
-    }
-}
-
 #[derive(Clone, Copy, Debug, Default, Deserialize, Eq, Hash, PartialEq, Serialize)]
 pub enum SpecialUsageMailbox {
     #[default]

Original file line number	Diff line number	Diff line change
`@@ -1208,12 +1208,7 @@ impl Account {`
`1208`	`1208`	`self.collection.contains_key(&h)`
`1209`	`1209`	`}`
`1210`	`1210`	`pub fn operation(&self, h: EnvelopeHash) -> Result<Box<dyn BackendOp>> {`
`1211`		`- let operation = self.backend.read().unwrap().operation(h)?;`
`1212`		`- Ok(if self.settings.account.read_only {`
`1213`		`- ReadOnlyOp::new(operation)`
`1214`		`- } else {`
`1215`		`- operation`
`1216`		`- })`
	`1211`	`+ self.backend.read().unwrap().operation(h)`
`1217`	`1212`	`}`
`1218`	`1213`
`1219`	`1214`	`pub fn special_use_mailbox(&self, special_use: SpecialUsageMailbox) -> Option<MailboxHash> {`