melib/maildir: log error instead of debug_assert!

epilys · epilys · commit 177e4928efc3 · 2025-01-31T15:29:33.000+02:00
In MaildirFilePathExt::to_envelope_hash(), don't panic if path is not a
regular file. The watching code might attempt to calculate the hash of a
file that has been removed by others.

Log error instead in the debug log level.

Signed-off-by: Manos Pitsidianakis &lt;manos@pitsidianak.is&gt;
diff --git a/melib/src/maildir/utilities.rs b/melib/src/maildir/utilities.rs
@@ -451,7 +451,31 @@ impl MaildirFilePathExt for Path {
     }
 
     fn to_envelope_hash(&self) -> EnvelopeHash {
-        debug_assert!(self.is_file());
+        #[cfg(debug_assertions)]
+        {
+            if !matches!(self.try_exists(), Ok(true)) {
+                log::debug!(
+                    "{}",
+                    Error::new("Path does not exist")
+                        .set_summary(format!(
+                            "Message with path {} does not exist.",
+                            self.display()
+                        ))
+                        .set_kind(ErrorKind::NotFound)
+                );
+            }
+            if !self.is_file() {
+                log::debug!(
+                    "{}",
+                    Error::new("Path is not a file")
+                        .set_summary(format!(
+                            "Message with path {} is not a file.",
+                            self.display()
+                        ))
+                        .set_kind(ErrorKind::ValueError)
+                );
+            }
+        }
         let mut hasher = DefaultHasher::default();
         self.hash(&mut hasher);
         EnvelopeHash(hasher.finish())
