Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nightly build #4451

Merged
merged 1 commit into from
Feb 29, 2024
Merged

Fix nightly build #4451

merged 1 commit into from
Feb 29, 2024

Conversation

dureuill
Copy link
Contributor

Pull Request

Related issue

Fixes #4441

What does this PR do?

Note

This one is going to be annoying a bit until the lint stabilizes:

  • We only get the warning on nightly, so we will discover them when it runs in the CI that uses the nightly compiler (not on regular PRs)
  • There's the case of TryInto/TryFrom traits. They have been added to the prelude in Rust edition 2021, so it means that useing them is a warning on nightly for 2021 edition crates (most crates), but not useing them is an error anywhere for 2018 Rust edition crates, such as milli

@dureuill dureuill requested a review from a team February 28, 2024 17:15
@dureuill dureuill added this to the v1.7.0 milestone Feb 28, 2024
@dureuill dureuill changed the base branch from main to release-v1.7.0 February 28, 2024 17:15
@dureuill
Copy link
Contributor Author

bors merge

@meili-bors meili-bors
Copy link
Contributor

meili-bors bot commented Feb 29, 2024

Build succeeded:

@meili-bors meili-bors bot merged commit a96b45d into release-v1.7.0 Feb 29, 2024
9 of 10 checks passed
@meili-bors meili-bors bot deleted the fix_nightly_build branch February 29, 2024 07:59
@dureuill dureuill mentioned this pull request Feb 29, 2024
Closed
@curquiza curquiza added the skip changelog The PR will not appear in the release changelogs label Feb 29, 2024
@meili-bot meili-bot added the v1.7.0 PRs/issues solved in v1.7.0 released on 2024-03-11 label Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@irevoire irevoire irevoire approved these changes

Assignees
No one assigned
Labels
skip changelog The PR will not appear in the release changelogs v1.7.0 PRs/issues solved in v1.7.0 released on 2024-03-11
Projects
None yet
Milestone
v1.7.0
Development

Successfully merging this pull request may close these issues.

CI failing with --no-default-features
4 participants
@dureuill @irevoire @curquiza @meili-bot