-
Notifications
You must be signed in to change notification settings - Fork 51
Feature/Multi-Arch images #291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| on: | ||
| push: | ||
| tags: | ||
| - 'v*' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
v0.24.0rc0 tag will be tagged as latest in this case
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Following the history of this repo, we didn't have a beta version yet. I think it is ok to keep the current change. But you're right, if we have plans to release betas here we will have problems :)
|
Merging it now since it is an urgent PR (I'm still waiting for the reviews @alallema and @bidoubiwa ). |
alallema
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for this PR @brunoocasali 🎉
| - name: Set up QEMU | ||
| uses: docker/setup-qemu-action@v2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need QEMU?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because we have multi-arch images to build, and QEMU is the way we have to emulate a different arch than the Action runner host. There is more explanation in the docker action https://github.com/docker/setup-qemu-action if you're interested :)
Pull Request
Related issue
Fixes #288
What does this PR do?