Skip to content

Conversation

@brunoocasali
Copy link
Member

Pull Request

Related issue

Fixes #288

What does this PR do?

  • Remove now "useless" actions
  • Create a new action that generates multi-arch builds

@brunoocasali brunoocasali added bug Something isn't working enhancement New feature or request labels Dec 1, 2022
on:
push:
tags:
- 'v*'
Copy link
Member

@curquiza curquiza Dec 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ the v0.24.0rc0 tag will be tagged as latest in this case

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following the history of this repo, we didn't have a beta version yet. I think it is ok to keep the current change. But you're right, if we have plans to release betas here we will have problems :)

@brunoocasali brunoocasali requested a review from alallema December 1, 2022 18:45
@brunoocasali
Copy link
Member Author

brunoocasali commented Dec 1, 2022

Merging it now since it is an urgent PR (I'm still waiting for the reviews @alallema and @bidoubiwa ).

@brunoocasali brunoocasali merged commit b2f4e2a into main Dec 1, 2022
@brunoocasali brunoocasali deleted the feature/multi-arch-images branch December 1, 2022 18:58
Copy link
Contributor

@alallema alallema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for this PR @brunoocasali 🎉

Comment on lines +16 to +17
- name: Set up QEMU
uses: docker/setup-qemu-action@v2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need QEMU?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because we have multi-arch images to build, and QEMU is the way we have to emulate a different arch than the Action runner host. There is more explanation in the docker action https://github.com/docker/setup-qemu-action if you're interested :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create image version that works in arm environments

4 participants